Skip to content

Commit 2d638a4

Browse files
authored
ENG-6169: Add skeleton item (#8)
1 parent 4fbce9d commit 2d638a4

File tree

7 files changed

+73
-39
lines changed

7 files changed

+73
-39
lines changed

demo/demo/demo.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ def index() -> rx.Component:
3030
"Item 10",
3131
],
3232
name="select",
33-
placeholder="Select an item",
33+
default_value="Select an item",
3434
on_value_change=lambda value: rx.toast.success(f"Value: {value}"),
3535
on_open_change=lambda value: rx.toast.success(f"Open: {value}"),
3636
),

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ version = "0.0.1"
44
description = "A set of reusable components built on top of Base UI and Tailwind, designed for use across any Reflex project"
55
readme = "README.md"
66
requires-python = ">=3.13"
7-
dependencies = ["reflex>=0.8.0a4"]
7+
dependencies = ["reflex>=0.8.0"]
88

99
[build-system]
1010
requires = ["hatchling", "uv-dynamic-versioning"]

reflex_ui/__init__.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
"components.base.badge": ["badge"],
88
"components.base.button": ["button"],
99
"components.base.select": ["select"],
10+
"components.base.skeleton": ["skeleton"],
1011
"components.base.theme_switcher": ["theme_switcher"],
1112
}
1213

reflex_ui/components/base/select.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -120,9 +120,6 @@ class SelectValue(SelectBaseComponent):
120120

121121
tag = "Select.Value"
122122

123-
# A placeholder to display before an item has been chosen.
124-
placeholder: Var[str]
125-
126123
# The render prop
127124
render_: Var[Component]
128125

@@ -438,7 +435,6 @@ def create(cls, *children, **props) -> Component:
438435
portal_props = {k: props.pop(k) for k in cls._portal_props & props.keys()}
439436

440437
# Get extracted values with defaults
441-
placeholder = trigger_props.get("placeholder", "")
442438
size = trigger_props.get("size", "md")
443439
items = items_props.get("items", [])
444440

@@ -486,7 +482,7 @@ def create(cls, *children, **props) -> Component:
486482
return SelectRoot.create(
487483
SelectTrigger.create(
488484
render_=button(
489-
SelectValue.create(placeholder=placeholder),
485+
SelectValue.create(),
490486
SelectIcon.create(select_arrow(class_name="size-4")),
491487
variant="outline",
492488
size=size,
Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
"""Custom skeleton component."""
2+
3+
from reflex.components.component import Component, memo
4+
from reflex.components.el import Div
5+
from reflex.vars import Var
6+
7+
from reflex_ui.utils.twmerge import cn
8+
9+
10+
class ClassNames:
11+
"""Class names for skeleton component."""
12+
13+
ROOT = "animate-pulse bg-secondary-6"
14+
15+
16+
@memo
17+
def skeleton_component(
18+
class_name: str | Var[str] = "",
19+
) -> Component:
20+
"""Skeleton component."""
21+
return Div.create(class_name=cn(ClassNames.ROOT, class_name))
22+
23+
24+
skeleton = skeleton_component

reflex_ui/components/base_ui.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
from reflex_ui.components.component import CoreComponent
66

77
PACKAGE_NAME = "@base-ui-components/react"
8-
PACKAGE_VERSION = "^1.0.0-beta.0"
8+
PACKAGE_VERSION = "^1.0.0-beta.1"
99

1010

1111
class BaseUIComponent(CoreComponent):

uv.lock

Lines changed: 44 additions & 31 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)