ruff rules plus other small changes (#2)

Author: carlosabadia

demo/demo/demo.py

@@ -2,14 +2,21 @@
 
 import reflex as rx
 
-import reflex_ui as rxui
+import reflex_ui as ui
 
 
 def index() -> rx.Component:
     # Welcome Page (Index)
     return rx.el.div(
-        rxui.button(rxui.hi("SmileIcon"), "Click me"),
-        class_name=rxui.cn(
+        ui.button(
+            ui.icon("SmileIcon"),
+            "Click me",
+            on_click=rx.toast.success(
+                "You are cool :)",
+                position="top-center",
+            ),
+        ),
+        class_name=ui.cn(
             "flex flex-col items-center justify-center h-screen", "bg-secondary-1"
         ),
     )

pyproject.toml

@@ -24,3 +24,43 @@ dev = ["pyright==1.1.402", "pre-commit"]
 
 [tool.codespell]
 skip = "*.pyi, uv.lock"
+
+[tool.ruff]
+target-version = "py313"
+output-format = "concise"
+lint.isort.split-on-trailing-comma = false
+lint.select = ["ALL"]
+lint.ignore = [
+    "A",
+    "ANN002",
+    "ANN003",
+    "ANN2",
+    "ANN4",
+    "ARG",
+    "BLE",
+    "C901",
+    "COM",
+    "D205",
+    "DTZ",
+    "E501",
+    "F403",
+    "FBT",
+    "FIX",
+    "G004",
+    "ISC003",
+    "PLC",
+    "PLR",
+    "PLW",
+    "PT011",
+    "PT012",
+    "PYI",
+    "RUF012",
+    "S",
+    "SLF",
+    "SLOT",
+    "TC",
+    "TD",
+    "TRY0",
+    "UP038",
+]
+lint.pydocstyle.convention = "google"

reflex_ui/__init__.py

@@ -11,8 +11,8 @@
 _SUBMOD_ATTRS = {
     **_REFLEX_UI_MAPPING,
     "components": ["base"],
-    "components.icons.hugeicon": ["hi"],
-    "components.icons.icon": ["icon"],
+    "components.icons.hugeicon": ["hi", "icon"],
+    "components.icons.others": ["spinner"],
     "utils.twmerge": ["cn"],
 }
 

reflex_ui/components/base/avatar.py

@@ -9,6 +9,8 @@
 
 
 class ClassNames:
+    """Class names for avatar components."""
+
     ROOT = "shrink-0 inline-flex size-6 items-center justify-center overflow-hidden rounded-full bg-secondary-1 align-middle text-base font-medium text-secondary-12 select-none"
     IMAGE = "size-full object-cover shrink-0"
     FALLBACK = "flex size-full items-center justify-center text-sm animate-pulse bg-secondary-6"
@@ -21,6 +23,7 @@ class AvatarBaseComponent(BaseUIComponent):
 
     @property
     def import_var(self):
+        """Return the import variable for the avatar component."""
         return ImportVar(tag="Avatar", package_path="", install=False)
 
 

reflex_ui/components/base/button.py

@@ -7,7 +7,7 @@
 from reflex.vars import Var
 
 from reflex_ui.components.component import CoreComponent
-from reflex_ui.components.icons.icon import spinner
+from reflex_ui.components.icons.others import spinner
 
 LiteralButtonVariant = Literal[
     "primary", "destructive", "outline", "secondary", "ghost", "link", "dark"
@@ -82,17 +82,21 @@ def create(cls, *children, **props) -> BaseButton:
 
     @staticmethod
     def validate_variant(variant: LiteralButtonVariant):
+        """Validate the button variant."""
         if variant not in BUTTON_VARIANTS["variant"]:
-            raise ValueError(
-                f"Invalid variant: {variant}. Available variants: {', '.join(BUTTON_VARIANTS['variant'].keys())}"
+            available_variants = ", ".join(BUTTON_VARIANTS["variant"].keys())
+            message = (
+                f"Invalid variant: {variant}. Available variants: {available_variants}"
             )
+            raise ValueError(message)
 
     @staticmethod
     def validate_size(size: LiteralButtonSize):
+        """Validate the button size."""
         if size not in BUTTON_VARIANTS["size"]:
-            raise ValueError(
-                f"Invalid size: {size}. Available sizes: {', '.join(BUTTON_VARIANTS['size'].keys())}"
-            )
+            available_sizes = ", ".join(BUTTON_VARIANTS["size"].keys())
+            message = f"Invalid size: {size}. Available sizes: {available_sizes}"
+            raise ValueError(message)
 
     def _exclude_props(self) -> list[str]:
         return [

reflex_ui/components/component.py

@@ -1,4 +1,4 @@
-"""Core component for all components"""
+"""Core component for all components."""
 
 from typing import Any
 
@@ -21,6 +21,7 @@ def set_class_name(cls, default_class_name: str, props: dict[str, Any]) -> None:
         Args:
             props: The component props dictionary
             default_class_name: The default class name to use
+
         """
         if "render_" in props:
             return

reflex_ui/components/icons/__init__.py

@@ -0,0 +1,19 @@
+"""Icons sub-package."""
+
+from reflex.utils import lazy_loader
+
+_SUBMODULES: set[str] = {
+    "hugeicon",
+    "others",
+}
+
+_SUBMOD_ATTRS: dict[str, list[str]] = {
+    "hugeicon": ["hi", "icon"],
+    "others": ["spinner"],
+}
+
+__getattr__, __dir__, __all__ = lazy_loader.attach(
+    __name__,
+    submodules=_SUBMODULES,
+    submod_attrs=_SUBMOD_ATTRS,
+)

reflex_ui/components/icons/hugeicon.py

@@ -39,6 +39,7 @@ def create(cls, *children, **props) -> Component:
 
         Returns:
             The created component.
+
         """
         if children and isinstance(children[0], str) and "icon" not in props:
             props["icon"] = children[0]
@@ -58,4 +59,4 @@ def create(cls, *children, **props) -> Component:
         return super().create(*children, **props)
 
 
-hi = HugeIcon.create
+hi = icon = HugeIcon.create

reflex_ui/components/icons/icon.py reflex_ui/components/icons/others.pyreflex_ui/components/icons/icon.py renamed to reflex_ui/components/icons/others.py

@@ -11,13 +11,14 @@
 def spinner_component(
     class_name: str | Var[str] = "",
 ) -> Component:
-    """A spinner SVG icon.
+    """Create a spinner SVG icon.
 
     Args:
         class_name: The class name of the spinner.
 
     Returns:
         The spinner SVG icon.
+
     """
     return svg(
         svg.path(

reflex_ui/utils/twmerge.py

@@ -15,6 +15,7 @@ def cn(
 
     Returns:
         Var: A Var representing the merged classes string.
+
     """
     return (
         Var(