Skip to content

Commit dd0fa31

Browse files
committed
update
1 parent dab2fa6 commit dd0fa31

File tree

1 file changed

+1
-9
lines changed

1 file changed

+1
-9
lines changed

reflex_ui/components/base/menu.py

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -544,7 +544,6 @@ class HighLevelMenu(MenuRoot):
544544
# Props for different component parts
545545
_item_props = {"close_on_click"}
546546
_trigger_props = {"placeholder", "size", "close_on_click"}
547-
_items_props = {"items"}
548547
_positioner_props = {
549548
"align",
550549
"align_offset",
@@ -573,22 +572,17 @@ def create(cls, *children, **props) -> Component:
573572
# Extract props for different parts
574573
item_props = {k: props.pop(k) for k in cls._item_props & props.keys()}
575574
trigger_props = {k: props.pop(k) for k in cls._trigger_props & props.keys()}
576-
items_props = {k: props.pop(k) for k in cls._items_props & props.keys()}
577575
positioner_props = {
578576
k: props.pop(k) for k in cls._positioner_props & props.keys()
579577
}
580578
portal_props = {k: props.pop(k) for k in cls._portal_props & props.keys()}
581579

582-
# Get the size of the menu
580+
items = props.pop("items", [])
583581
size = trigger_props.get("size", "md")
584-
# Get extracted values with defaults
585-
items = items_props.get("items", [])
586582
trigger_label = trigger_props.get("placeholder", "Open Menu")
587583

588-
# Helper function to create menu item from either string or tuple
589584
def create_menu_item(item: str | tuple[str, EventHandler]) -> Component:
590585
if isinstance(item, tuple):
591-
# Handle tuple: (label, on_click_handler)
592586
label, on_click_handler = item
593587
return MenuItem.create(
594588
render_=button(
@@ -601,7 +595,6 @@ def create_menu_item(item: str | tuple[str, EventHandler]) -> Component:
601595
),
602596
**item_props,
603597
)
604-
# Handle string
605598
return MenuItem.create(
606599
render_=button(
607600
item,
@@ -613,7 +606,6 @@ def create_menu_item(item: str | tuple[str, EventHandler]) -> Component:
613606
**item_props,
614607
)
615608

616-
# Create the items children
617609
if isinstance(items, Var):
618610
items_children = foreach(items, create_menu_item)
619611
else:

0 commit comments

Comments
 (0)