You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Clean up constants: consolidate scattered constants and remove unused ones (#1435)
* Consolidate scattered constants and remove unused ones
- Move MAX_FILE_SIZE_MB, MAX_IMAGES_COUNT, PROMPT_MAP from hero.py to constants.py
- Move CONTRIBUTION_URL, BUGS_URL from open_source.py to constants.py
- Move FONT_FAMILY, DOC_BORDER_RADIUS from styles.py to constants.py
- Move PRICING_TABLE_STYLES dict from pricing/table.py to constants.py
- Move SPLINE_SCENE_URL from spline.py to constants.py
- Consolidate repeated reflex.dev URLs and @getreflex in meta.py
- Remove unused PYNECONE_URL and MONTHLY_USERS constants
- Update all import statements to use consolidated constants
- Verify application functionality is preserved
Co-Authored-By: Alek <[email protected]>
* Add back PYNECONE_URL constant
- PYNECONE_URL is still referenced in blog/2023-06-28-rebrand-to-reflex.md
- This constant is needed for historical blog post about the rebrand
- Application now runs successfully with all constants properly consolidated
Co-Authored-By: Alek <[email protected]>
* Add verification script for constants consolidation
- Script tests that all new constants can be imported successfully
- Verifies that updated imports work correctly across the codebase
- Helps ensure constants consolidation doesn't break functionality
Co-Authored-By: Alek <[email protected]>
* Move styling constants back to appropriate files per feedback
- Move FONT_FAMILY back to fonts.py as local constant
- Move PRICING_TABLE_STYLES back to table.py as STYLES dict
- DOC_BORDER_RADIUS remains in styles.py where it belongs
- Remove imports of styling constants from constants.py
- Update verification script to test non-styling constants only
- Maintain all other consolidated constants in constants.py
Addresses feedback: 'no styles should be in the constants'
Co-Authored-By: Alek <[email protected]>
* Complete removal of styling constants from constants.py
- Remove FONT_FAMILY, DOC_BORDER_RADIUS, and PRICING_TABLE_STYLES from constants.py
- Update templates/docpage/blocks/code.py to use DOC_BORDER_RADIUS from styles module
- Ensure styles.py properly defines DOC_BORDER_RADIUS locally
- All styling constants now properly separated from main constants file
Co-Authored-By: Alek <[email protected]>
* Address greptile bot comments: move runtime version and domain to constants
- Add SPLINE_RUNTIME_VERSION constant for @splinetool/runtime version
- Add REFLEX_DOMAIN constant for consistent twitter:domain usage
- Update spline.py to use SPLINE_RUNTIME_VERSION constant
- Update meta.py to use REFLEX_DOMAIN for all twitter:domain fields
- Improves consistency and maintainability of configuration values
Addresses greptile bot suggestions on PR #1435
Co-Authored-By: Alek <[email protected]>
* Remove verification script per PR feedback
- Remove verify_constants.py as it's not needed for production
- Addresses Alek's comment that verification file is unnecessary
Co-Authored-By: Alek <[email protected]>
---------
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: Alek <[email protected]>
0 commit comments