Skip to content

Commit ef2f0c6

Browse files
authored
fix implicit str to int conversions and improve compile time by memoization of navbar (#1204)
1 parent fb661cb commit ef2f0c6

File tree

3 files changed

+8
-1
lines changed

3 files changed

+8
-1
lines changed

docs/events/background_events.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,10 @@ class MyTaskState(rx.State):
4545
running: bool = False
4646
_n_tasks: int = 0
4747

48+
@rx.event
49+
def set_max_counter(self, value: str):
50+
self.max_counter = int(value)
51+
4852
@rx.event(background=True)
4953
async def my_task(self):
5054
async with self:

docs/vars/base_vars.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,9 @@ class BackendVarState(rx.State):
127127
def generate_more(self):
128128
self._backend = np.append(self._backend, [random.randint(0, 100) for _ in range(random.randint(0, 100))])
129129

130+
@rx.event
131+
def set_limit(self, value: str):
132+
self.limit = int(value)
130133

131134
def backend_var_example():
132135
return rx.vstack(

pcweb/components/docpage/navbar/navbar.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -370,7 +370,7 @@ def new_component_section() -> rx.Component:
370370
),
371371
)
372372

373-
373+
@rx.memo
374374
def navbar() -> rx.Component:
375375
return rx.box(
376376
hosting_banner(),

0 commit comments

Comments
 (0)