Skip to content

Commit f9d62c7

Browse files
authored
[HOS-211] Mobile view + docs hosting banner fix (#1078)
1 parent 3e6c9ed commit f9d62c7

File tree

2 files changed

+32
-11
lines changed

2 files changed

+32
-11
lines changed

pcweb/components/hosting_banner.py

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -15,16 +15,15 @@ class HostingBannerState(rx.State):
1515
show_banner: bool = True
1616

1717
def hide_banner(self):
18-
print("hide_banner")
1918
self.show_banner = False
2019

20+
2121
def hosting_banner() -> rx.Component:
2222
return rx.cond(
2323
HostingBannerState.show_banner,
24-
rx.desktop_only(rx.box(
24+
rx.box(
2525
rx.link(
2626
rx.box(
27-
rx.text(""),
2827
rx.text(
2928
"Reflex Cloud - ",
3029
rx.el.span(
@@ -35,14 +34,21 @@ def hosting_banner() -> rx.Component:
3534
),
3635
rx.el.button(
3736
"Launching Soon",
38-
class_name="text-slate-11 h-[1.5rem] rounded-md bg-slate-4 px-1.5 text-sm font-semibold z-[1]",
37+
class_name="text-slate-11 h-[1.5rem] rounded-md bg-slate-4 px-1.5 text-sm font-semibold z-[1] items-center justify-center shrink-0",
3938
),
4039
class_name="flex items-center gap-4",
4140
),
4241
href="/hosting",
42+
underline="none",
43+
class_name="mr-7 lg:mr-0",
44+
),
45+
rx.icon(
46+
"x",
47+
on_click=HostingBannerState.hide_banner,
48+
size=16,
49+
class_name="z-[1] cursor-pointer hover:!text-slate-11 transition-color !text-slate-9 absolute right-4",
4350
),
44-
rx.icon("x", on_click=HostingBannerState.hide_banner, size=16, color=rx.color("slate", 9), class_name="absolute right-4 z-[1]"),
4551
glow(),
46-
class_name="px-4 lg:px-6 w-screen h-auto lg:h-[40px] shadow-[inset_0_-1px_0_0_var(--c-slate-3)] flex items-center justify-center bg-slate-1 flex-row gap-4 overflow-hidden relative lg:py-0 py-2 max-w-full",
47-
))
52+
class_name="px-4 lg:px-6 w-screen h-auto lg:h-[3.5rem] shadow-[inset_0_-1px_0_0_var(--c-slate-3)] flex items-center justify-center bg-slate-1 flex-row gap-4 overflow-hidden relative lg:py-0 py-2 max-w-full",
53+
),
4854
)

pcweb/templates/docpage/docpage.py

Lines changed: 19 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -286,7 +286,7 @@ def breadcrumb(path: str, nav_sidebar: rx.Component):
286286
class_name="font-sm text-slate-8 mobile-only",
287287
)
288288
)
289-
289+
from pcweb.components.hosting_banner import HostingBannerState
290290
# Return the list of breadcrumb items with separators
291291
return rx.box(
292292
docs_sidebar_drawer(
@@ -303,7 +303,11 @@ def breadcrumb(path: str, nav_sidebar: rx.Component):
303303
rx.icon(tag="chevron-down", size=14, class_name="!text-slate-9"),
304304
class_name="p-[0.563rem] mobile-only",
305305
),
306-
class_name="relative z-10 flex flex-row justify-between items-center gap-4 lg:gap-0 border-slate-4 bg-slate-1 mt-12 lg:mt-[119px] mb-6 lg:mb-12 p-[0.5rem_1rem_0.5rem_1rem] lg:p-0 border-b lg:border-none w-full",
306+
class_name="relative z-10 flex flex-row justify-between items-center gap-4 lg:gap-0 border-slate-4 bg-slate-1 mt-12 mb-6 lg:mb-12 p-[0.5rem_1rem_0.5rem_1rem] lg:p-0 border-b lg:border-none w-full" + rx.cond(
307+
HostingBannerState.show_banner,
308+
" lg:mt-[175px]",
309+
" lg:mt-[119px]",
310+
),
307311
)
308312

309313

@@ -414,6 +418,7 @@ def wrapper(*args, **kwargs) -> rx.Component:
414418
from pcweb.components.docpage.navbar import navbar
415419
from pcweb.components.docpage.sidebar import get_prev_next
416420
from pcweb.components.docpage.sidebar import sidebar as sb
421+
from pcweb.components.hosting_banner import HostingBannerState
417422

418423
# Create the docpage sidebar.
419424
sidebar = sb(url=path, width="300px")
@@ -494,7 +499,12 @@ def wrapper(*args, **kwargs) -> rx.Component:
494499
rx.el.main(
495500
rx.box(
496501
sidebar,
497-
class_name="mt-[90px] h-full shrink-0 desktop-only lg:w-[24%]",
502+
class_name="h-full shrink-0 desktop-only lg:w-[24%]"
503+
+ rx.cond(
504+
HostingBannerState.show_banner,
505+
" mt-[146px]",
506+
" mt-[90px]",
507+
),
498508
),
499509
rx.box(
500510
rx.box(
@@ -567,7 +577,12 @@ def wrapper(*args, **kwargs) -> rx.Component:
567577
),
568578
class_name="fixed flex flex-col justify-start gap-4 p-[0.875rem_0.5rem_0px_0.5rem] w-full max-w-[300px] max-h-[80vh] overflow-hidden",
569579
),
570-
class_name="mt-[90px] h-full shrink-0 w-[16%]"
580+
class_name="h-full shrink-0 w-[16%]"
581+
+ rx.cond(
582+
HostingBannerState.show_banner,
583+
" mt-[146px]",
584+
" mt-[90px]",
585+
)
571586
+ (" hidden xl:flex" if right_sidebar else " hidden"),
572587
),
573588
class_name="justify-center flex flex-row mx-auto mt-0 max-w-[94.5em] h-full min-h-screen w-full",

0 commit comments

Comments
 (0)