Skip to content

Commit 07a9093

Browse files
committed
fix test_connection_banner.py: expect SocketRecord JSON
1 parent 223747d commit 07a9093

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

reflex/utils/token_manager.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -442,7 +442,7 @@ async def _get_token_owner(self, token: str, refresh: bool = False) -> str | Non
442442
self.token_to_socket[token] = socket_record
443443
self.sid_to_token[socket_record.sid] = token
444444
return socket_record.instance_id
445-
console.error(f"Redis token owner not found for token {token}")
445+
console.warn(f"Redis token owner not found for token {token}")
446446
except Exception as e:
447447
console.error(f"Redis error getting token owner: {e}")
448448
return None

tests/integration/test_connection_banner.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ async def test_connection_banner(connection_banner: AppHarness):
170170
await connection_banner.state_manager.redis.get(
171171
app_token_manager._get_redis_key(token)
172172
)
173-
== b"1"
173+
== f'{{"instance_id": "{app_token_manager.instance_id}", "sid": "{sid_before}"}}'.encode()
174174
)
175175

176176
delay_button = driver.find_element(By.ID, "delay")
@@ -221,17 +221,17 @@ async def test_connection_banner(connection_banner: AppHarness):
221221

222222
# After reconnecting, the token association should be re-established.
223223
app_token_manager = connection_banner.token_manager()
224+
# Make sure the new connection has a different websocket sid.
225+
sid_after = app_token_manager.token_to_sid[token]
226+
assert sid_before != sid_after
224227
if isinstance(connection_banner.state_manager, StateManagerRedis):
225228
assert isinstance(app_token_manager, RedisTokenManager)
226229
assert (
227230
await connection_banner.state_manager.redis.get(
228231
app_token_manager._get_redis_key(token)
229232
)
230-
== b"1"
233+
== f'{{"instance_id": "{app_token_manager.instance_id}", "sid": "{sid_after}"}}'.encode()
231234
)
232-
# Make sure the new connection has a different websocket sid.
233-
sid_after = app_token_manager.token_to_sid[token]
234-
assert sid_before != sid_after
235235

236236
# Count should have incremented after coming back up
237237
assert connection_banner.poll_for_value(counter_element, exp_not_equal="1") == "2"

0 commit comments

Comments
 (0)