Skip to content

Commit 24cf764

Browse files
authored
Enable wide assortion of ruff rules (#5372)
* enable ASYNC * enable RET * enable RSE * enable most of PT * enable RUF006 * enable RUF008 * enable SIM115 * enable B008 * enable EM * enable FLY * enable INP but disable it for tests * enable NPY * enable PD * enable PIE * enable TID * addendum to ASYNC, fixes redis ci * merge with main * replace msg, with msg * replace segment
1 parent 5ecc8e9 commit 24cf764

File tree

199 files changed

+1248
-1341
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

199 files changed

+1248
-1341
lines changed

pyi_hashes.json

Lines changed: 51 additions & 51 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
"reflex/components/lucide/icon.pyi": "775e6686e491fd46f28a00b19699db3d",
4343
"reflex/components/markdown/markdown.pyi": "73d3116fa28450c90f25b21107285daa",
4444
"reflex/components/moment/moment.pyi": "ab1d6618159693014fdf22b4aa84c877",
45-
"reflex/components/next/base.pyi": "5ea32ecae5c64e02217c8895783f9ccb",
45+
"reflex/components/next/base.pyi": "5e75245c2b0ee4715f89efaf42d101d8",
4646
"reflex/components/next/image.pyi": "8c305c03019d37c07560c154a05bf5dd",
4747
"reflex/components/next/link.pyi": "cc438e48a9f31bf16f1cdb6e16017477",
4848
"reflex/components/next/video.pyi": "8f5694a4a2118c5297e2eba479b6f018",
@@ -52,68 +52,68 @@
5252
"reflex/components/radix/primitives/accordion.pyi": "a31599f0b2a1a69a10917137dcb75a9d",
5353
"reflex/components/radix/primitives/base.pyi": "fc910c9bd364b57e1c092fbf8889158d",
5454
"reflex/components/radix/primitives/drawer.pyi": "8f20bac0e36266398be1a124218bda87",
55-
"reflex/components/radix/primitives/form.pyi": "11402dfac6256f2220c5c830008b8b8b",
55+
"reflex/components/radix/primitives/form.pyi": "efd2ec67535eb1b1eefaafc0d5e36d8a",
5656
"reflex/components/radix/primitives/progress.pyi": "98b4add410a80a353ab503ad577169c2",
5757
"reflex/components/radix/primitives/slider.pyi": "573837a7d8d90deaf57c911faffed254",
5858
"reflex/components/radix/themes/__init__.pyi": "a15f9464ad99f248249ffa8e6deea4cf",
5959
"reflex/components/radix/themes/base.pyi": "526db93a3f52bb00ad220f8744eba797",
6060
"reflex/components/radix/themes/color_mode.pyi": "f7515dccd1e315dc28a3cbbe2eabe7ff",
6161
"reflex/components/radix/themes/components/__init__.pyi": "87bb9ffff641928562da1622d2ca5993",
62-
"reflex/components/radix/themes/components/alert_dialog.pyi": "9f19bcdb4588a7f76596d142a0ac0950",
63-
"reflex/components/radix/themes/components/aspect_ratio.pyi": "ecace271fa2c518c429594556ddf4389",
64-
"reflex/components/radix/themes/components/avatar.pyi": "51d3f65fb3e5c4abda00cc8bf4a7e50c",
65-
"reflex/components/radix/themes/components/badge.pyi": "1ecf1253abb3a7e293146d4cc6327ceb",
66-
"reflex/components/radix/themes/components/button.pyi": "70b5258eb4c2716af39f1b2e5bfc4cbb",
67-
"reflex/components/radix/themes/components/callout.pyi": "aa9d08f1246d9c7f97ad6a3ac4d5fcb5",
68-
"reflex/components/radix/themes/components/card.pyi": "60374dee8093535874fac2901d993aaf",
69-
"reflex/components/radix/themes/components/checkbox.pyi": "0766d08ef379dd919134ff22481528c6",
70-
"reflex/components/radix/themes/components/checkbox_cards.pyi": "7cb7297d3e3388efbd2b678278bb034b",
71-
"reflex/components/radix/themes/components/checkbox_group.pyi": "0878853ed682b3930fbf0c4f0a655ba2",
72-
"reflex/components/radix/themes/components/context_menu.pyi": "4f64ded6e04727c9d24ef2518f9db540",
73-
"reflex/components/radix/themes/components/data_list.pyi": "a07a9e89e0fb3f10db78549029fecb37",
74-
"reflex/components/radix/themes/components/dialog.pyi": "8b9725b561c253b37562279ce94a99e9",
75-
"reflex/components/radix/themes/components/dropdown_menu.pyi": "1a0bdafb4fa95044c8edcc9e83efacf5",
76-
"reflex/components/radix/themes/components/hover_card.pyi": "f15aedcd77ce8a7ab7f7470780fe4035",
77-
"reflex/components/radix/themes/components/icon_button.pyi": "3887d4225f5ead440e8aeecceec990fd",
78-
"reflex/components/radix/themes/components/inset.pyi": "3dbda9fbe5f660c8bfda717aceb0dbdc",
79-
"reflex/components/radix/themes/components/popover.pyi": "bf2cd9e744a23305b74ff888d980993f",
80-
"reflex/components/radix/themes/components/progress.pyi": "a5610ee8a8eab36b1aada37e866f9494",
81-
"reflex/components/radix/themes/components/radio.pyi": "69f5c47aee9a1179c273a4e4765c6099",
82-
"reflex/components/radix/themes/components/radio_cards.pyi": "6f323c60aff4da0f576655c32d208bb8",
83-
"reflex/components/radix/themes/components/radio_group.pyi": "4d9d918832555a5fa3efa4a71df15ad2",
84-
"reflex/components/radix/themes/components/scroll_area.pyi": "7b507e661c87b08061df4e13e73ab47b",
85-
"reflex/components/radix/themes/components/segmented_control.pyi": "a848ceda014c4f64a1adc89202598c15",
86-
"reflex/components/radix/themes/components/select.pyi": "b223797edc8b9d3341c105c796d392de",
87-
"reflex/components/radix/themes/components/separator.pyi": "92c789575a1336bb3e5dcd2012fb68a1",
88-
"reflex/components/radix/themes/components/skeleton.pyi": "34340e43123c2aaa89f042411cae06ec",
89-
"reflex/components/radix/themes/components/slider.pyi": "023bc8fada28779c0d2f8f14f8b30fec",
90-
"reflex/components/radix/themes/components/spinner.pyi": "941dfcee9581f116af7c7116084a6938",
91-
"reflex/components/radix/themes/components/switch.pyi": "9e3dfd7dfa16166bb2adc5fb60b25438",
92-
"reflex/components/radix/themes/components/table.pyi": "5643313daebc43bc6246d0beee81505f",
93-
"reflex/components/radix/themes/components/tabs.pyi": "0bc64cfc23592767477af649339f0e4e",
94-
"reflex/components/radix/themes/components/text_area.pyi": "8d976ea7e23b0f5942aeb3a0d295835c",
95-
"reflex/components/radix/themes/components/text_field.pyi": "77b28c7caebea3fdb4ba5ef6f3ce19f3",
96-
"reflex/components/radix/themes/components/tooltip.pyi": "050ecd7a591e358170d332b1e9c07059",
62+
"reflex/components/radix/themes/components/alert_dialog.pyi": "3832f3e8a6a3eed1bfa969efea627b72",
63+
"reflex/components/radix/themes/components/aspect_ratio.pyi": "f90aa46ef8b29bd076d98321de96315a",
64+
"reflex/components/radix/themes/components/avatar.pyi": "d40e8e25a9c007f2554590abd116a095",
65+
"reflex/components/radix/themes/components/badge.pyi": "422c4d1586e6b22d00a2d5f002989651",
66+
"reflex/components/radix/themes/components/button.pyi": "fc5c290d6df9b5197c65036c9edafa38",
67+
"reflex/components/radix/themes/components/callout.pyi": "f81f5032d90e36705fd5b5ba30d3f3ab",
68+
"reflex/components/radix/themes/components/card.pyi": "fdf71624bdeeba391d1c0545039dd2e7",
69+
"reflex/components/radix/themes/components/checkbox.pyi": "006614845a236f6611c656c05a8db394",
70+
"reflex/components/radix/themes/components/checkbox_cards.pyi": "289d0fd448f654e17f3132234e9d4983",
71+
"reflex/components/radix/themes/components/checkbox_group.pyi": "8eb8cca3e0c5885150576cc60ba19fea",
72+
"reflex/components/radix/themes/components/context_menu.pyi": "5f178adef09c0f36103e33b11326cb2a",
73+
"reflex/components/radix/themes/components/data_list.pyi": "4014ea23eec39cfe98032852665a92ca",
74+
"reflex/components/radix/themes/components/dialog.pyi": "8dc1a09d30aff2fcf28e28988fca170f",
75+
"reflex/components/radix/themes/components/dropdown_menu.pyi": "0cd87cddbe9a83dcfa9cbcc4f9d98dd4",
76+
"reflex/components/radix/themes/components/hover_card.pyi": "973a4911f68cec60f40a8e2ca5e42770",
77+
"reflex/components/radix/themes/components/icon_button.pyi": "55e0b8c8233d1e5a52a8c09c959e4989",
78+
"reflex/components/radix/themes/components/inset.pyi": "a215de3b29b2133626cbfc83544305fe",
79+
"reflex/components/radix/themes/components/popover.pyi": "1fa6f96aef6f148f110fa208aa449ab7",
80+
"reflex/components/radix/themes/components/progress.pyi": "1d0f827e8db089418b2786f82d55512d",
81+
"reflex/components/radix/themes/components/radio.pyi": "a8fcc63bf42129196d70a9571647d4bb",
82+
"reflex/components/radix/themes/components/radio_cards.pyi": "b5222b86e418920de2ef988752f0b577",
83+
"reflex/components/radix/themes/components/radio_group.pyi": "7b95ee1fcd41186f2c7670be273d134f",
84+
"reflex/components/radix/themes/components/scroll_area.pyi": "28352b03135ef2065876a5199b9c150a",
85+
"reflex/components/radix/themes/components/segmented_control.pyi": "0477ee74033ed0f67cd2cb94a47ccea9",
86+
"reflex/components/radix/themes/components/select.pyi": "9c63eb11bab2d2913431ec0c13111b6d",
87+
"reflex/components/radix/themes/components/separator.pyi": "f8c9c18ea7f67e8287f4ebc5c09790b5",
88+
"reflex/components/radix/themes/components/skeleton.pyi": "aeff3cbc53989c4824a5e49e9ea3bbca",
89+
"reflex/components/radix/themes/components/slider.pyi": "242e107d73ec14d984cb88fa8f23ad68",
90+
"reflex/components/radix/themes/components/spinner.pyi": "5050ba710b0c950c29f69cafd93f6c4f",
91+
"reflex/components/radix/themes/components/switch.pyi": "61729a28148bc17acd20e48c12f60a54",
92+
"reflex/components/radix/themes/components/table.pyi": "81c77cecf78ddb3e931c9a5f0f8eccde",
93+
"reflex/components/radix/themes/components/tabs.pyi": "6facf7ebd344f8995934a167af01a9e5",
94+
"reflex/components/radix/themes/components/text_area.pyi": "eef90fcc66990c44f3c0540862877cba",
95+
"reflex/components/radix/themes/components/text_field.pyi": "92552297cc747dd3aae6f382699e319d",
96+
"reflex/components/radix/themes/components/tooltip.pyi": "5e17b67e50410f1124d2150237eab7cf",
9797
"reflex/components/radix/themes/layout/__init__.pyi": "9a52c5b283c864be70b51a8fd6120392",
98-
"reflex/components/radix/themes/layout/base.pyi": "a3a869acd2a1c5025580697ae5e2c024",
99-
"reflex/components/radix/themes/layout/box.pyi": "d2d2b266eed53e866c5b5ad8cee292e4",
98+
"reflex/components/radix/themes/layout/base.pyi": "6a255a392bf0d54c924c26e673248971",
99+
"reflex/components/radix/themes/layout/box.pyi": "731cc26fc41d2b174ed4e901f5292479",
100100
"reflex/components/radix/themes/layout/center.pyi": "e0592f33bdec5586a7377ca986f1a966",
101-
"reflex/components/radix/themes/layout/container.pyi": "691ec3a849be5f42c0b5d6ba1b243b55",
102-
"reflex/components/radix/themes/layout/flex.pyi": "ed2746b5cd2b3d9ef73e370f85a66043",
103-
"reflex/components/radix/themes/layout/grid.pyi": "6543e4413501fd41a20ff4d58931b584",
101+
"reflex/components/radix/themes/layout/container.pyi": "3c5ddf03873da9bf0f5308d5d6429097",
102+
"reflex/components/radix/themes/layout/flex.pyi": "8d8cfd4f00e21aac8d165ded0f7c600f",
103+
"reflex/components/radix/themes/layout/grid.pyi": "412f164266f810671cf38ca5e50d9cfd",
104104
"reflex/components/radix/themes/layout/list.pyi": "32ce23a3f851698ac0d609e616bd3605",
105-
"reflex/components/radix/themes/layout/section.pyi": "2b9b826ab42eae3f8cf4d1899dea4b33",
105+
"reflex/components/radix/themes/layout/section.pyi": "2904116ccc24dcb66285ff2daaac1875",
106106
"reflex/components/radix/themes/layout/spacer.pyi": "3def4df36e8eecdfba0a7d2f1890b908",
107-
"reflex/components/radix/themes/layout/stack.pyi": "1b09d9123358d430ad6c66343d0e9c92",
107+
"reflex/components/radix/themes/layout/stack.pyi": "b7ec458d254cd09058ca805d553199da",
108108
"reflex/components/radix/themes/typography/__init__.pyi": "ef0ba71353dcac1f3546de45f8721bae",
109-
"reflex/components/radix/themes/typography/blockquote.pyi": "04de9fdb22583d87faaba5619bdc6e3e",
110-
"reflex/components/radix/themes/typography/code.pyi": "bd58d40878c3488f1ba58a122e78f4e7",
111-
"reflex/components/radix/themes/typography/heading.pyi": "91bfc9176f7e9ef33d1f69711ceddbe1",
112-
"reflex/components/radix/themes/typography/link.pyi": "febffdd31eee7a4f67d12d6e10a13516",
113-
"reflex/components/radix/themes/typography/text.pyi": "d2ba2f718acd0eaf7b5923fe6a27d59c",
114-
"reflex/components/react_player/audio.pyi": "bd7e024d39ac641f8279ee0f6afd7985",
109+
"reflex/components/radix/themes/typography/blockquote.pyi": "fdd2214a8416bcd4ba644a0bd0015c5a",
110+
"reflex/components/radix/themes/typography/code.pyi": "2e0b487ed1128422bfc4105928dbb18a",
111+
"reflex/components/radix/themes/typography/heading.pyi": "bec5af8f72e3c0a764d77e16608da4a1",
112+
"reflex/components/radix/themes/typography/link.pyi": "196d6ef6c1a15f2d7180a973e8753ea5",
113+
"reflex/components/radix/themes/typography/text.pyi": "33f91de2a0ae94e5802e7c8f0971b1df",
114+
"reflex/components/react_player/audio.pyi": "231e9338b19330a6963928f7e90cb40f",
115115
"reflex/components/react_player/react_player.pyi": "40db798bcb7fa40207d24f49722135ae",
116-
"reflex/components/react_player/video.pyi": "22d84a7f57be13ece90cb30536d76c7d",
116+
"reflex/components/react_player/video.pyi": "f92885d49cdc565b95b20820d09e2ca2",
117117
"reflex/components/recharts/__init__.pyi": "a060a4abcd018165bc499173e723cf9e",
118118
"reflex/components/recharts/cartesian.pyi": "601e1acb0ad6bd93ce371d763220aabe",
119119
"reflex/components/recharts/charts.pyi": "2f0a39f9c02de83d9e2d97763b4411af",

pyproject.toml

Lines changed: 17 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -91,50 +91,51 @@ lint.ignore = [
9191
"ANN2",
9292
"ANN4",
9393
"ARG",
94-
"ASYNC",
95-
"B008",
9694
"BLE",
9795
"C901",
9896
"COM",
9997
"D205",
10098
"DTZ",
10199
"E501",
102-
"EM",
103100
"F403",
104101
"FBT",
105102
"FIX",
106-
"FLY",
107103
"G004",
108-
"INP",
109104
"ISC003",
110-
"NPY",
111-
"PD",
112-
"PIE",
113105
"PLC",
114106
"PLR",
115107
"PLW",
116-
"PT",
108+
"PT011",
109+
"PT012",
117110
"PYI",
118-
"RET",
119-
"RSE",
120-
"RUF006",
121-
"RUF008",
122111
"RUF012",
123112
"S",
124-
"SIM115",
125113
"SLF",
126114
"SLOT",
127115
"TC",
128116
"TD",
129-
"TID",
130117
"TRY0",
131118
"UP038",
132119
]
133120
lint.pydocstyle.convention = "google"
121+
lint.flake8-bugbear.extend-immutable-calls = [
122+
"reflex.utils.types.Unset",
123+
"reflex.vars.base.Var.create",
124+
]
134125

135126
[tool.ruff.lint.per-file-ignores]
136127
"__init__.py" = ["F401"]
137-
"tests/*.py" = ["ANN001", "D100", "D103", "D104", "B018", "PERF", "T", "N"]
128+
"tests/*.py" = [
129+
"ANN001",
130+
"D100",
131+
"D103",
132+
"D104",
133+
"INP",
134+
"B018",
135+
"PERF",
136+
"T",
137+
"N",
138+
]
138139
"benchmarks/*.py" = ["ANN001", "D100", "D103", "D104", "B018", "PERF", "T", "N"]
139140
"reflex/.templates/*.py" = ["D100", "D103", "D104"]
140141
"*.pyi" = ["D301", "D415", "D417", "D418", "E742", "N", "PGH"]

reflex/.templates/apps/blank/code/blank.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@
88
class State(rx.State):
99
"""The app state."""
1010

11-
...
12-
1311

1412
def index() -> rx.Component:
1513
# Welcome Page (Index)

0 commit comments

Comments
 (0)