Skip to content

Commit 3ebdf3e

Browse files
committed
Fix pickle test expectation for test_connection_banner
1 parent 8ad27db commit 3ebdf3e

File tree

1 file changed

+10
-11
lines changed

1 file changed

+10
-11
lines changed

tests/integration/test_connection_banner.py

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
"""Test case for displaying the connection banner when the websocket drops."""
22

3+
import pickle
34
from collections.abc import Generator
45

56
import pytest
@@ -10,7 +11,7 @@
1011
from reflex.environment import environment
1112
from reflex.istate.manager.redis import StateManagerRedis
1213
from reflex.testing import AppHarness, WebDriver
13-
from reflex.utils.token_manager import RedisTokenManager
14+
from reflex.utils.token_manager import RedisTokenManager, SocketRecord
1415

1516
from .utils import SessionStorage
1617

@@ -166,11 +167,10 @@ async def test_connection_banner(connection_banner: AppHarness):
166167
sid_before = app_token_manager.token_to_sid[token]
167168
if isinstance(connection_banner.state_manager, StateManagerRedis):
168169
assert isinstance(app_token_manager, RedisTokenManager)
169-
assert (
170-
await connection_banner.state_manager.redis.get(
171-
app_token_manager._get_redis_key(token)
172-
)
173-
== f'{{"instance_id": "{app_token_manager.instance_id}", "sid": "{sid_before}"}}'.encode()
170+
assert await connection_banner.state_manager.redis.get(
171+
app_token_manager._get_redis_key(token)
172+
) == pickle.dumps(
173+
SocketRecord(instance_id=app_token_manager.instance_id, sid=sid_before)
174174
)
175175

176176
delay_button = driver.find_element(By.ID, "delay")
@@ -226,11 +226,10 @@ async def test_connection_banner(connection_banner: AppHarness):
226226
assert sid_before != sid_after
227227
if isinstance(connection_banner.state_manager, StateManagerRedis):
228228
assert isinstance(app_token_manager, RedisTokenManager)
229-
assert (
230-
await connection_banner.state_manager.redis.get(
231-
app_token_manager._get_redis_key(token)
232-
)
233-
== f'{{"instance_id": "{app_token_manager.instance_id}", "sid": "{sid_after}"}}'.encode()
229+
assert await connection_banner.state_manager.redis.get(
230+
app_token_manager._get_redis_key(token)
231+
) == pickle.dumps(
232+
SocketRecord(instance_id=app_token_manager.instance_id, sid=sid_after)
234233
)
235234

236235
# Count should have incremented after coming back up

0 commit comments

Comments
 (0)