hide __getattribute__ from type checking (#6056)

* hide __getattribute__ from type checking

* ok precommit

* remove pyright ignores for isinstance checks

* fix precommit for test

Author: adhami3310

reflex/istate/proxy.py

@@ -758,7 +758,7 @@ def _mark_dirty(
         Raises:
             ImmutableStateError: if the StateProxy is not mutable.
         """
-        if not self._self_state._is_mutable():
+        if not self._self_state._is_mutable():  # pyright: ignore[reportAttributeAccessIssue]
             msg = (
                 "Background task StateProxy is immutable outside of a context "
                 "manager. Use `async with self` to modify state."

reflex/istate/shared.py

@@ -190,6 +190,9 @@ async def _link_to(self, token: str) -> Self:
         if not token:
             msg = "Cannot link shared state to empty token."
             raise ReflexRuntimeError(msg)
+        if not isinstance(self, SharedState):
+            msg = "Can only link SharedState instances."
+            raise RuntimeError(msg)
         if self._linked_to == token:
             return self  # already linked to this token
         if self._linked_to and self._linked_to != token:
@@ -215,6 +218,10 @@ async def _unlink(self):
         """
         from reflex.istate.manager import get_state_manager
 
+        if not isinstance(self, SharedState):
+            msg = "Can only unlink SharedState instances."
+            raise ReflexRuntimeError(msg)
+
         state_name = self.get_full_name()
         if (
             not self._reflex_internal_links
@@ -272,6 +279,9 @@ async def _internal_patch_linked_state(
                 _substate_key(token, type(self))
             )
         linked_state = await linked_root_state.get_state(type(self))
+        if not isinstance(linked_state, SharedState):
+            msg = f"Linked state for token {token} is not a SharedState."
+            raise ReflexRuntimeError(msg)
         # Avoid unnecessary dirtiness of shared state when there are no changes.
         if type(self) not in self._held_locks[token]:
             self._held_locks[token][type(self)] = linked_state

reflex/state.py

@@ -1350,7 +1350,7 @@ def _check_overwritten_dynamic_args(cls, args: list[str]):
         for substate in cls.get_substates():
             substate._check_overwritten_dynamic_args(args)
 
-    def __getattribute__(self, name: str) -> Any:
+    def _get_attribute(self, name: str) -> Any:
         """Get the state var.
 
         If the var is inherited, get the var from the parent state.
@@ -1408,6 +1408,9 @@ def __getattribute__(self, name: str) -> Any:
 
         return value
 
+    if not TYPE_CHECKING:
+        __getattribute__ = _get_attribute
+
     def __setattr__(self, name: str, value: Any):
         """Set the attribute.
 

tests/integration/test_client_storage.py

@@ -669,6 +669,7 @@ def set_sub_sub(var: str, value: str):
     # Ensure the state is gone (not hydrated)
     async def poll_for_not_hydrated():
         state = await client_side.get_state(_substate_key(token or "", state_name))
+        assert isinstance(state, State)
         return not state.is_hydrated
 
     assert await AppHarness._poll_for_async(poll_for_not_hydrated)
@@ -723,30 +724,30 @@ async def get_sub_state():
 
     async def poll_for_c1_set():
         sub_state = await get_sub_state()
-        return sub_state.c1 == "c1 post expire"
+        return sub_state.c1 == "c1 post expire"  # pyright: ignore[reportAttributeAccessIssue]
 
     assert await AppHarness._poll_for_async(poll_for_c1_set)
     sub_state = await get_sub_state()
-    assert sub_state.c1 == "c1 post expire"
-    assert sub_state.c2 == "c2 value"
-    assert sub_state.c3 == ""
-    assert sub_state.c4 == "c4 value"
-    assert sub_state.c5 == "c5 value"
-    assert sub_state.c6 == "c6 value"
-    assert sub_state.c7 == "c7 value"
-    assert sub_state.l1 == "l1 value"
-    assert sub_state.l2 == "l2 value"
-    assert sub_state.l3 == "l3 value"
-    assert sub_state.l4 == "l4 value"
-    assert sub_state.s1 == "s1 value"
-    assert sub_state.s2 == "s2 value"
-    assert sub_state.s3 == "s3 value"
+    assert sub_state.c1 == "c1 post expire"  # pyright: ignore[reportAttributeAccessIssue]
+    assert sub_state.c2 == "c2 value"  # pyright: ignore[reportAttributeAccessIssue]
+    assert sub_state.c3 == ""  # pyright: ignore[reportAttributeAccessIssue]
+    assert sub_state.c4 == "c4 value"  # pyright: ignore[reportAttributeAccessIssue]
+    assert sub_state.c5 == "c5 value"  # pyright: ignore[reportAttributeAccessIssue]
+    assert sub_state.c6 == "c6 value"  # pyright: ignore[reportAttributeAccessIssue]
+    assert sub_state.c7 == "c7 value"  # pyright: ignore[reportAttributeAccessIssue]
+    assert sub_state.l1 == "l1 value"  # pyright: ignore[reportAttributeAccessIssue]
+    assert sub_state.l2 == "l2 value"  # pyright: ignore[reportAttributeAccessIssue]
+    assert sub_state.l3 == "l3 value"  # pyright: ignore[reportAttributeAccessIssue]
+    assert sub_state.l4 == "l4 value"  # pyright: ignore[reportAttributeAccessIssue]
+    assert sub_state.s1 == "s1 value"  # pyright: ignore[reportAttributeAccessIssue]
+    assert sub_state.s2 == "s2 value"  # pyright: ignore[reportAttributeAccessIssue]
+    assert sub_state.s3 == "s3 value"  # pyright: ignore[reportAttributeAccessIssue]
     sub_sub_state = sub_state.substates[
         client_side.get_state_name("_client_side_sub_sub_state")
     ]
-    assert sub_sub_state.c1s == "c1s value"
-    assert sub_sub_state.l1s == "l1s value"
-    assert sub_sub_state.s1s == "s1s value"
+    assert sub_sub_state.c1s == "c1s value"  # pyright: ignore[reportAttributeAccessIssue]
+    assert sub_sub_state.l1s == "l1s value"  # pyright: ignore[reportAttributeAccessIssue]
+    assert sub_sub_state.s1s == "s1s value"  # pyright: ignore[reportAttributeAccessIssue]
 
     # clear the cookie jar and local storage, ensure state reset to default
     driver.delete_all_cookies()

tests/integration/test_component_state.py

@@ -167,8 +167,8 @@ async def test_component_state_app(component_state_app: AppHarness):
     a_state = root_state.substates[a_state_name]
     b_state = root_state.substates[b_state_name]
     assert a_state._backend_vars != a_state.backend_vars
-    assert a_state._be == a_state._backend_vars["_be"] == 3
-    assert b_state._be is None
+    assert a_state._be == a_state._backend_vars["_be"] == 3  # pyright: ignore[reportAttributeAccessIssue]
+    assert b_state._be is None  # pyright: ignore[reportAttributeAccessIssue]
     assert b_state._backend_vars["_be"] is None
 
     assert count_b.text == "0"
@@ -183,7 +183,7 @@ async def test_component_state_app(component_state_app: AppHarness):
     a_state = root_state.substates[a_state_name]
     b_state = root_state.substates[b_state_name]
     assert b_state._backend_vars != b_state.backend_vars
-    assert b_state._be == b_state._backend_vars["_be"] == 2
+    assert b_state._be == b_state._backend_vars["_be"] == 2  # pyright: ignore[reportAttributeAccessIssue]
 
     # Check locally-defined substate style
     count_c = driver.find_element(By.ID, "count-c")

tests/integration/test_computed_vars.py

@@ -203,8 +203,8 @@ async def test_computed_vars(
     token = f"{token}_{full_state_name}"
     state = (await computed_vars.get_state(token)).substates[state_name]
     assert state is not None
-    assert state.count1_backend == 0
-    assert state._count1_backend == 0
+    assert state.count1_backend == 0  # pyright: ignore[reportAttributeAccessIssue]
+    assert state._count1_backend == 0  # pyright: ignore[reportAttributeAccessIssue]
 
     # test that backend var is not rendered
     count1_backend = driver.find_element(By.ID, "count1_backend")
@@ -259,9 +259,9 @@ async def test_computed_vars(
     )
     state = (await computed_vars.get_state(token)).substates[state_name]
     assert state is not None
-    assert state.count1_backend == 1
+    assert state.count1_backend == 1  # pyright: ignore[reportAttributeAccessIssue]
     assert count1_backend.text == ""
-    assert state._count1_backend == 1
+    assert state._count1_backend == 1  # pyright: ignore[reportAttributeAccessIssue]
     assert count1_backend_.text == ""
 
     mark_dirty.click()

tests/integration/test_dynamic_routes.py

@@ -23,7 +23,7 @@ class DynamicState(rx.State):
 
         @rx.event
         def on_load(self):
-            page_data = f"{self.router.page.path}-{self.page_id or 'no page id'}"
+            page_data = f"{self.router.page.path}-{self.page_id or 'no page id'}"  # pyright: ignore[reportAttributeAccessIssue]
             print(f"on_load: {page_data}")
             self.order.append(page_data)
 
@@ -43,7 +43,7 @@ def on_load_static(self):
         @rx.var
         def next_page(self) -> str:
             try:
-                return str(int(self.page_id) + 1)
+                return str(int(self.page_id) + 1)  # pyright: ignore[reportAttributeAccessIssue]
             except ValueError:
                 return "0"
 
@@ -81,7 +81,7 @@ class ArgState(rx.State):
 
         @rx.var(cache=False)
         def arg(self) -> int:
-            return int(self.arg_str or 0)
+            return int(self.arg_str or 0)  # pyright: ignore[reportAttributeAccessIssue]
 
     class ArgSubState(ArgState):
         @rx.var
@@ -90,7 +90,7 @@ def cached_arg(self) -> int:
 
         @rx.var
         def cached_arg_str(self) -> str:
-            return self.arg_str
+            return self.arg_str  # pyright: ignore[reportAttributeAccessIssue]
 
     @rx.page(route="/arg/[arg_str]")
     def arg() -> rx.Component:
@@ -238,11 +238,11 @@ async def _backend_state():
         async def _check():
             return (await _backend_state()).substates[
                 dynamic_state_name
-            ].order == exp_order
+            ].order == exp_order  # pyright: ignore[reportAttributeAccessIssue]
 
         await AppHarness._poll_for_async(_check, timeout=10)
         assert (
-            list((await _backend_state()).substates[dynamic_state_name].order)
+            list((await _backend_state()).substates[dynamic_state_name].order)  # pyright: ignore[reportAttributeAccessIssue]
             == exp_order
         )
 

tests/integration/test_event_actions.py

@@ -265,10 +265,10 @@ def poll_for_order(
 
     async def _poll_for_order(exp_order: list[str]):
         async def _check():
-            return (await _backend_state(event_action, token)).order == exp_order
+            return (await _backend_state(event_action, token)).order == exp_order  # pyright: ignore[reportAttributeAccessIssue]
 
         await AppHarness._poll_for_async(_check)
-        assert (await _backend_state(event_action, token)).order == exp_order
+        assert (await _backend_state(event_action, token)).order == exp_order  # pyright: ignore[reportAttributeAccessIssue]
 
     return _poll_for_order
 
@@ -358,12 +358,12 @@ async def test_event_actions_throttle_debounce(
     # Wait until the debounce event shows up
     async def _debounce_received():
         state = await _backend_state(event_action, token)
-        return state.order and state.order[-1] == "on_click_debounce"
+        return state.order and state.order[-1] == "on_click_debounce"  # pyright: ignore[reportAttributeAccessIssue]
 
     await AppHarness._poll_for_async(_debounce_received)
 
     # This test is inherently racy, so ensure the `on_click_throttle` event is fired approximately the expected number of times.
-    final_event_order = (await _backend_state(event_action, token)).order
+    final_event_order = (await _backend_state(event_action, token)).order  # pyright: ignore[reportAttributeAccessIssue]
     n_on_click_throttle_received = final_event_order.count("on_click_throttle")
     print(
         f"Expected ~{exp_events} on_click_throttle events, received {n_on_click_throttle_received}"

tests/integration/test_event_chain.py

@@ -462,11 +462,11 @@ async def test_event_chain_click(
 
     async def _has_all_events():
         return len(
-            (await event_chain.get_state(token)).substates[state_name].event_order
+            (await event_chain.get_state(token)).substates[state_name].event_order  # pyright: ignore[reportAttributeAccessIssue]
         ) == len(exp_event_order)
 
     await AppHarness._poll_for_async(_has_all_events)
-    event_order = (await event_chain.get_state(token)).substates[state_name].event_order
+    event_order = (await event_chain.get_state(token)).substates[state_name].event_order  # pyright: ignore[reportAttributeAccessIssue]
     assert event_order == exp_event_order
 
 
@@ -515,13 +515,13 @@ async def test_event_chain_on_load(
 
     async def _has_all_events():
         return len(
-            (await event_chain.get_state(token)).substates[state_name].event_order
+            (await event_chain.get_state(token)).substates[state_name].event_order  # pyright: ignore[reportAttributeAccessIssue]
         ) == len(exp_event_order)
 
     await AppHarness._poll_for_async(_has_all_events)
     backend_state = (await event_chain.get_state(token)).substates[state_name]
-    assert backend_state.event_order == exp_event_order
-    assert backend_state.is_hydrated is True
+    assert backend_state.event_order == exp_event_order  # pyright: ignore[reportAttributeAccessIssue]
+    assert backend_state.is_hydrated is True  # pyright: ignore[reportAttributeAccessIssue]
 
 
 @pytest.mark.parametrize(
@@ -582,11 +582,11 @@ async def test_event_chain_on_mount(
 
     async def _has_all_events():
         return len(
-            (await event_chain.get_state(token)).substates[state_name].event_order
+            (await event_chain.get_state(token)).substates[state_name].event_order  # pyright: ignore[reportAttributeAccessIssue]
         ) == len(exp_event_order)
 
     await AppHarness._poll_for_async(_has_all_events)
-    event_order = (await event_chain.get_state(token)).substates[state_name].event_order
+    event_order = (await event_chain.get_state(token)).substates[state_name].event_order  # pyright: ignore[reportAttributeAccessIssue]
     assert list(event_order) == exp_event_order
 
 

tests/integration/test_form_submit.py

@@ -232,7 +232,7 @@ async def get_form_data():
         return (
             (await form_submit.get_state(f"{token}_{full_state_name}"))
             .substates[state_name]
-            .form_data
+            .form_data  # pyright: ignore[reportAttributeAccessIssue]
         )
 
     # wait for the form data to arrive at the backend