print warning instead of error with invalid icon (#4959)

* print warning instead of error with invalid icon

* dang it darglint

* pyi

* fix unit tests

Author: adhami3310

reflex/components/lucide/icon.py

@@ -1,7 +1,7 @@
 """Lucide Icon component."""
 
 from reflex.components.component import Component
-from reflex.utils import format
+from reflex.utils import console, format
 from reflex.utils.imports import ImportVar
 from reflex.vars.base import LiteralVar, Var
 from reflex.vars.sequence import LiteralStringVar, StringVar
@@ -33,7 +33,6 @@ def create(cls, *children, **props) -> Component:
 
         Raises:
             AttributeError: The errors tied to bad usage of the Icon component.
-            ValueError: If the icon tag is invalid.
             TypeError: If the icon name is not a string.
 
         Returns:
@@ -73,15 +72,18 @@ def create(cls, *children, **props) -> Component:
             if isinstance(tag, str):
                 icons_sorted = sorted(
                     LUCIDE_ICON_LIST,
-                    key=lambda s: format.length_of_largest_common_substring(tag, s),
+                    key=lambda s, tag=tag: format.length_of_largest_common_substring(
+                        tag, s
+                    ),
                     reverse=True,
                 )
             else:
                 icons_sorted = LUCIDE_ICON_LIST
-            raise ValueError(
-                f"Invalid icon tag: {tag}. Please use one of the following: {', '.join(icons_sorted[0:25])}, ..."
-                "\nSee full list at https://reflex.dev/docs/library/data-display/icon/#icons-list."
+            console.warn(
+                f"Invalid icon tag: {tag}. Please use one of the following: {', '.join(icons_sorted[0:10])}, ..."
+                "\nSee full list at https://reflex.dev/docs/library/data-display/icon/#icons-list. Using 'circle-help' icon instead."
             )
+            tag = "circle-help"
 
         if tag in LUCIDE_ICON_MAPPING_OVERRIDE:
             props["tag"] = LUCIDE_ICON_MAPPING_OVERRIDE[tag]

reflex/components/lucide/icon.pyi

@@ -103,7 +103,6 @@ class Icon(LucideIconComponent):
 
         Raises:
             AttributeError: The errors tied to bad usage of the Icon component.
-            ValueError: If the icon tag is invalid.
             TypeError: If the icon name is not a string.
 
         Returns:

tests/units/components/lucide/test_icon.py

@@ -22,8 +22,8 @@ def test_icon_missing_tag():
 
 
 def test_icon_invalid_tag():
-    with pytest.raises(ValueError):
-        _ = Icon.create("invalid-tag")
+    invalid = Icon.create("invalid-tag")
+    assert invalid.tag == "CircleHelpIcon"
 
 
 def test_icon_multiple_children():