Skip to content

Commit 5606d1c

Browse files
authored
update slider event spec (#5828)
* update slider event spec * precommit
1 parent 7331abc commit 5606d1c

File tree

3 files changed

+6
-21
lines changed

3 files changed

+6
-21
lines changed

pyi_hashes.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@
5050
"reflex/components/radix/primitives/drawer.pyi": "c6ad2f60217fe25952f3a1ba88fbd72a",
5151
"reflex/components/radix/primitives/form.pyi": "8a5ec180a50acdc35dfe53e4e65c20e0",
5252
"reflex/components/radix/primitives/progress.pyi": "b26c99c1d827c0f599fff344746aeec3",
53-
"reflex/components/radix/primitives/slider.pyi": "c03b716ffbbc3e1a0c766951de04e83b",
53+
"reflex/components/radix/primitives/slider.pyi": "be343dcd0558917b054683c99d539a43",
5454
"reflex/components/radix/themes/__init__.pyi": "582b4a7ead62b2ae8605e17fa084c063",
5555
"reflex/components/radix/themes/base.pyi": "3e1ccd5ce5fef0b2898025193ee3d069",
5656
"reflex/components/radix/themes/color_mode.pyi": "744548322db3ce069c4b56341f274671",
@@ -82,7 +82,7 @@
8282
"reflex/components/radix/themes/components/select.pyi": "f7196bf70b506b21ccce95301679b8b5",
8383
"reflex/components/radix/themes/components/separator.pyi": "4db0b99e3ffc63c59a8d6d973c25495a",
8484
"reflex/components/radix/themes/components/skeleton.pyi": "4bae01522e3f4efe5d04262c53f23571",
85-
"reflex/components/radix/themes/components/slider.pyi": "3a5a53e655a74baf2110e46b526b6fb1",
85+
"reflex/components/radix/themes/components/slider.pyi": "305a34c14ca8656ca9267e4c31aaa388",
8686
"reflex/components/radix/themes/components/spinner.pyi": "476098d606a9271ff49d7bbbae285acd",
8787
"reflex/components/radix/themes/components/switch.pyi": "1edf811e25894d44e7ec5a8f031ff86a",
8888
"reflex/components/radix/themes/components/table.pyi": "6e49e5bf41fa9314a27887ce13f52955",

reflex/components/radix/primitives/slider.py

Lines changed: 3 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
from reflex.components.component import Component, ComponentNamespace
99
from reflex.components.radix.primitives.base import RadixPrimitiveComponentWithClassName
10-
from reflex.event import EventHandler
10+
from reflex.event import EventHandler, passthrough_event_spec
1111
from reflex.vars.base import Var
1212

1313
LiteralSliderOrientation = Literal["horizontal", "vertical"]
@@ -20,20 +20,6 @@ class SliderComponent(RadixPrimitiveComponentWithClassName):
2020
library = "@radix-ui/[email protected]"
2121

2222

23-
def on_value_event_spec(
24-
value: Var[list[int]],
25-
) -> tuple[Var[list[int]]]:
26-
"""Event handler spec for the value event.
27-
28-
Args:
29-
value: The value of the event.
30-
31-
Returns:
32-
The event handler spec.
33-
"""
34-
return (value,)
35-
36-
3723
class SliderRoot(SliderComponent):
3824
"""The Slider component containing all slider parts."""
3925

@@ -63,10 +49,10 @@ class SliderRoot(SliderComponent):
6349
min_steps_between_thumbs: Var[int]
6450

6551
# Fired when the value of a thumb changes.
66-
on_value_change: EventHandler[on_value_event_spec]
52+
on_value_change: EventHandler[passthrough_event_spec(list[float])]
6753

6854
# Fired when a thumb is released.
69-
on_value_commit: EventHandler[on_value_event_spec]
55+
on_value_commit: EventHandler[passthrough_event_spec(list[float])]
7056

7157
def add_style(self) -> dict[str, Any] | None:
7258
"""Add style to the component.

reflex/components/radix/themes/components/slider.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,8 @@
1313
from reflex.vars.base import Var
1414

1515
on_value_event_spec = (
16-
passthrough_event_spec(list[int | float]),
17-
passthrough_event_spec(list[int]),
1816
passthrough_event_spec(list[float]),
17+
passthrough_event_spec(list[int]),
1918
)
2019

2120

0 commit comments

Comments
 (0)