Skip to content

Commit 593ec23

Browse files
committed
Temporarily downpin @radix-ui/themes <3.1.5 (#4370)
* Temporarily downpin @radix-ui/themes <3.1.5 A visual/style regression was introduced in @radix-ui/themes 3.1.5 as described in radix-ui/themes#627 which reflex needs to avoid. * Get expected radix library version from component
1 parent 1f7e7af commit 593ec23

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

reflex/components/radix/themes/base.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,9 @@ class RadixThemesComponent(Component):
112112

113113
library = "@radix-ui/themes@^3.0.0"
114114

115+
# Temporary pin < 3.1.5 until radix-ui/themes#627 is resolved.
116+
library = library + " && <3.1.5"
117+
115118
# "Fake" prop color_scheme is used to avoid shadowing CSS prop "color".
116119
_rename_props: Dict[str, str] = {"colorScheme": "color"}
117120

tests/units/components/core/test_banner.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
ConnectionPulser,
55
WebsocketTargetURL,
66
)
7+
from reflex.components.radix.themes.base import RadixThemesComponent
78
from reflex.components.radix.themes.typography.text import Text
89

910

@@ -24,7 +25,7 @@ def test_connection_banner():
2425
"react",
2526
"$/utils/context",
2627
"$/utils/state",
27-
"@radix-ui/themes@^3.0.0",
28+
RadixThemesComponent().library or "",
2829
"$/env.json",
2930
)
3031
)
@@ -42,7 +43,7 @@ def test_connection_modal():
4243
"react",
4344
"$/utils/context",
4445
"$/utils/state",
45-
"@radix-ui/themes@^3.0.0",
46+
RadixThemesComponent().library or "",
4647
"$/env.json",
4748
)
4849
)

0 commit comments

Comments
 (0)