deprecate state auto settings at compile time (#5746)

* move state_auth_setters deprecation warning to compile time

* Also warn for setvar

Author: masenf

reflex/state.py

@@ -225,8 +225,20 @@ def __call__(self, *args: Any) -> EventSpec:
             EventHandlerValueError: If the given Var name is not a str
             NotImplementedError: If the setter for the given Var is async
         """
+        from reflex.config import get_config
         from reflex.utils.exceptions import EventHandlerValueError
 
+        config = get_config()
+        if config.state_auto_setters is None:
+            console.deprecate(
+                feature_name="state_auto_setters defaulting to True",
+                reason="The default value will be changed to False in a future release. Set state_auto_setters explicitly or define setters explicitly. "
+                f"Used {self.state_cls.__name__}.setvar without defining it.",
+                deprecation_version="0.8.9",
+                removal_version="0.9.0",
+                dedupe=True,
+            )
+
         if args:
             if not isinstance(args[0], str):
                 msg = f"Var name must be passed as a string, got {args[0]!r}"
@@ -1096,19 +1108,22 @@ def _set_var(cls, name: str, prop: Var):
         setattr(cls, name, prop)
 
     @classmethod
-    def _create_event_handler(cls, fn: Any):
+    def _create_event_handler(
+        cls, fn: Any, event_handler_cls: type[EventHandler] = EventHandler
+    ):
         """Create an event handler for the given function.
 
         Args:
             fn: The function to create an event handler for.
+            event_handler_cls: The event handler class to use.
 
         Returns:
             The event handler.
         """
         # Check if function has stored event_actions from decorator
         event_actions = getattr(fn, "_rx_event_actions", {})
 
-        return EventHandler(
+        return event_handler_cls(
             fn=fn, state_full_name=cls.get_full_name(), event_actions=event_actions
         )
 
@@ -1125,9 +1140,34 @@ def _create_setter(cls, name: str, prop: Var):
             name: The name of the var.
             prop: The var to create a setter for.
         """
+        from reflex.config import get_config
+
+        config = get_config()
+        _create_event_handler_kwargs = {}
+
+        if config.state_auto_setters is None:
+
+            class EventHandlerDeprecatedSetter(EventHandler):
+                def __call__(self, *args, **kwargs):
+                    console.deprecate(
+                        feature_name="state_auto_setters defaulting to True",
+                        reason="The default value will be changed to False in a future release. Set state_auto_setters explicitly or define setters explicitly. "
+                        f"Used {setter_name} in {cls.__name__} without defining it.",
+                        deprecation_version="0.8.9",
+                        removal_version="0.9.0",
+                        dedupe=True,
+                    )
+                    return super().__call__(*args, **kwargs)
+
+            _create_event_handler_kwargs["event_handler_cls"] = (
+                EventHandlerDeprecatedSetter
+            )
+
         setter_name = Var._get_setter_name_for_name(name)
         if setter_name not in cls.__dict__:
-            event_handler = cls._create_event_handler(prop._get_setter(name))
+            event_handler = cls._create_event_handler(
+                prop._get_setter(name), **_create_event_handler_kwargs
+            )
             cls.event_handlers[setter_name] = event_handler
             setattr(cls, setter_name, event_handler)
 

reflex/vars/base.py

@@ -930,10 +930,6 @@ def _get_setter(self, name: str) -> Callable[[BaseState, Any], None]:
         Returns:
             A function that that creates a setter for the var.
         """
-        from reflex.config import get_config
-
-        config = get_config()
-
         setter_name = Var._get_setter_name_for_name(name)
 
         def setter(state: Any, value: Any):
@@ -943,15 +939,6 @@ def setter(state: Any, value: Any):
                 state: The state within which we add the setter function.
                 value: The value to set.
             """
-            if config.state_auto_setters is None:
-                console.deprecate(
-                    feature_name="state_auto_setters defaulting to True",
-                    reason="The default value will be changed to False in a future release. Set state_auto_setters explicitly or define setters explicitly. "
-                    f"Used {setter_name} in {type(state).__name__} without defining it.",
-                    deprecation_version="0.8.9",
-                    removal_version="0.9.0",
-                    dedupe=True,
-                )
             if self._var_type in [int, float]:
                 try:
                     value = self._var_type(value)