Skip to content

Commit b44bbc8

Browse files
authored
import var perf improvements (#4813)
* import var perf improvements * use tuples over iterator * the only thing that matters * maybe tuple map is faster than tuple list comprehension * do it in one list comprehension
1 parent aac61c6 commit b44bbc8

File tree

1 file changed

+6
-11
lines changed

1 file changed

+6
-11
lines changed

reflex/components/component.py

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -51,13 +51,7 @@
5151
)
5252
from reflex.style import Style, format_as_emotion
5353
from reflex.utils import format, imports, types
54-
from reflex.utils.imports import (
55-
ImmutableParsedImportDict,
56-
ImportDict,
57-
ImportVar,
58-
ParsedImportDict,
59-
parse_imports,
60-
)
54+
from reflex.utils.imports import ImportDict, ImportVar, ParsedImportDict, parse_imports
6155
from reflex.vars import VarData
6256
from reflex.vars.base import (
6357
CachedVarOperation,
@@ -1208,7 +1202,7 @@ def _should_transpile(self, dep: str | None) -> bool:
12081202
Returns:
12091203
True if the dependency should be transpiled.
12101204
"""
1211-
return (
1205+
return bool(self.transpile_packages) and (
12121206
dep in self.transpile_packages
12131207
or format.format_library_name(dep or "") in self.transpile_packages
12141208
)
@@ -1291,9 +1285,10 @@ def _get_imports(self) -> ParsedImportDict:
12911285
event_imports = Imports.EVENTS if self.event_triggers else {}
12921286

12931287
# Collect imports from Vars used directly by this component.
1294-
var_datas = [var._get_all_var_data() for var in self._get_vars()]
1295-
var_imports: List[ImmutableParsedImportDict] = [
1296-
var_data.imports for var_data in var_datas if var_data is not None
1288+
var_imports = [
1289+
var_data.imports
1290+
for var in self._get_vars()
1291+
if (var_data := var._get_all_var_data()) is not None
12971292
]
12981293

12991294
added_import_dicts: list[ParsedImportDict] = []

0 commit comments

Comments
 (0)