Skip to content

Commit cfe0aa2

Browse files
authored
make get_props use get_js_fields (#5361)
* make get_props use get_js_fields * we want all fields
1 parent 3456adb commit cfe0aa2

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

reflex/components/component.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -286,10 +286,11 @@ def __new__(cls, name: str, bases: tuple[type], namespace: dict[str, Any]) -> ty
286286

287287
namespace["_own_fields"] = own_fields
288288
namespace["_inherited_fields"] = inherited_fields
289-
namespace["_fields"] = inherited_fields | own_fields
289+
all_fields = inherited_fields | own_fields
290+
namespace["_fields"] = all_fields
290291
namespace["_js_fields"] = {
291292
key: value
292-
for key, value in own_fields.items()
293+
for key, value in all_fields.items()
293294
if value.is_javascript is True
294295
}
295296
return super().__new__(cls, name, bases, namespace)
@@ -1015,7 +1016,7 @@ def get_props(cls) -> set[str]:
10151016
Returns:
10161017
The unique fields.
10171018
"""
1018-
return set(cls.get_fields()) - set(Component.get_fields())
1019+
return set(cls.get_js_fields())
10191020

10201021
@classmethod
10211022
@functools.cache

0 commit comments

Comments
 (0)