disable stateful app detection (#5583)

* disable stateful app detection

* disable state for test tailwind

* wghat

Author: adhami3310

reflex/app.py

@@ -400,6 +400,9 @@ class App(MiddlewareMixin, LifespanMixin):
     # The state class to use for the app.
     _state: type[BaseState] | None = None
 
+    # Whether to enable state for the app. If False, the app will not use state.
+    enable_state: bool = True
+
     # Class to manage many client states.
     _state_manager: StateManager | None = None
 
@@ -480,7 +483,8 @@ def __post_init__(self):
             if issubclass(clz, AppMixin):
                 clz._init_mixin(self)
 
-        self._setup_state()
+        if self.enable_state:
+            self._enable_state()
 
         # Set up the admin dash.
         self._setup_admin_dash()
@@ -495,7 +499,7 @@ def _enable_state(self) -> None:
         """Enable state for the app."""
         if not self._state:
             self._state = State
-            self._setup_state()
+        self._setup_state()
 
     def _setup_state(self) -> None:
         """Set up the state for the app.
@@ -847,14 +851,10 @@ def _compile_page(self, route: str, save_page: bool = True):
             save_page: If True, the compiled page is saved to self._pages.
         """
         n_states_before = len(all_base_state_classes)
-        component, enable_state = compiler.compile_unevaluated_page(
-            route, self._unevaluated_pages[route], self._state, self.style, self.theme
+        component = compiler.compile_unevaluated_page(
+            route, self._unevaluated_pages[route], self.style, self.theme
         )
 
-        # Indicate that the app should use state.
-        if enable_state:
-            self._enable_state()
-
         # Indicate that evaluating this page creates one or more state classes.
         if len(all_base_state_classes) > n_states_before:
             self._stateful_pages[route] = None
@@ -1146,7 +1146,6 @@ def get_compilation_time() -> str:
                 for route in stateful_pages:
                     console.debug(f"BE Evaluating stateful page: {route}")
                     self._compile_page(route, save_page=False)
-                self._enable_state()
             self._add_optional_endpoints()
             return
 
@@ -1345,8 +1344,6 @@ def memoized_toast_provider():
         for route, component in zip(self._pages, page_components, strict=True):
             ExecutorSafeFunctions.COMPONENTS[route] = component
 
-        ExecutorSafeFunctions.STATE = self._state
-
         modify_files_tasks: list[tuple[str, str, Callable[[str], str]]] = []
 
         with console.timing("Compile to Javascript"), executor as executor:

reflex/compiler/compiler.py

@@ -145,15 +145,11 @@ def _compile_contexts(state: type[BaseState] | None, theme: Component | None) ->
     )
 
 
-def _compile_page(
-    component: BaseComponent,
-    state: type[BaseState] | None,
-) -> str:
-    """Compile the component given the app state.
+def _compile_page(component: BaseComponent) -> str:
+    """Compile the component.
 
     Args:
         component: The component to compile.
-        state: The app state.
 
     Returns:
         The compiled component.
@@ -163,15 +159,12 @@ def _compile_page(
     imports = utils.compile_imports(imports)
 
     # Compile the code to render the component.
-    kwargs = {"state_name": state.get_name()} if state is not None else {}
-
     return templates.PAGE.render(
         imports=imports,
         dynamic_imports=component._get_all_dynamic_imports(),
         custom_codes=component._get_all_custom_code(),
         hooks=component._get_all_hooks(),
         render=component.render(),
-        **kwargs,
     )
 
 
@@ -556,15 +549,12 @@ def compile_contexts(
     return output_path, _compile_contexts(state, theme)
 
 
-def compile_page(
-    path: str, component: BaseComponent, state: type[BaseState] | None
-) -> tuple[str, str]:
+def compile_page(path: str, component: BaseComponent) -> tuple[str, str]:
     """Compile a single page.
 
     Args:
         path: The path to compile the page to.
         component: The component to compile.
-        state: The app state.
 
     Returns:
         The path and code of the compiled page.
@@ -573,7 +563,7 @@ def compile_page(
     output_path = utils.get_page_path(path)
 
     # Add the style to the component.
-    code = _compile_page(component, state)
+    code = _compile_page(component)
     return output_path, code
 
 
@@ -788,16 +778,14 @@ def into_component(component: Component | ComponentCallable) -> Component:
 def compile_unevaluated_page(
     route: str,
     page: UnevaluatedPage,
-    state: type[BaseState] | None = None,
     style: ComponentStyle | None = None,
     theme: Component | None = None,
-) -> tuple[Component, bool]:
+) -> Component:
     """Compiles an uncompiled page into a component and adds meta information.
 
     Args:
         route: The route of the page.
         page: The uncompiled page object.
-        state: The state of the app.
         style: The style of the page.
         theme: The theme of the page.
 
@@ -813,21 +801,6 @@ def compile_unevaluated_page(
 
         component._add_style_recursive(style or {}, theme)
 
-        enable_state = False
-        # Ensure state is enabled if this page uses state.
-        if state is None:
-            if page.on_load or component._has_stateful_event_triggers():
-                enable_state = True
-            else:
-                for var in component._get_vars(include_children=True):
-                    var_data = var._get_all_var_data()
-                    if not var_data:
-                        continue
-                    if not var_data.state:
-                        continue
-                    enable_state = True
-                    break
-
         from reflex.utils.format import make_default_page_title
 
         component = Fragment.create(component)
@@ -856,7 +829,7 @@ def compile_unevaluated_page(
             e.add_note(f"Happened while evaluating page {route!r}")
         raise
     else:
-        return component, enable_state
+        return component
 
 
 class ExecutorSafeFunctions:
@@ -886,7 +859,6 @@ class ExecutorSafeFunctions:
 
     COMPONENTS: dict[str, BaseComponent] = {}
     UNCOMPILED_PAGES: dict[str, UnevaluatedPage] = {}
-    STATE: type[BaseState] | None = None
 
     @classmethod
     def compile_page(cls, route: str) -> tuple[str, str]:
@@ -898,7 +870,7 @@ def compile_page(cls, route: str) -> tuple[str, str]:
         Returns:
             The path and code of the compiled page.
         """
-        return compile_page(route, cls.COMPONENTS[route], cls.STATE)
+        return compile_page(route, cls.COMPONENTS[route])
 
     @classmethod
     def compile_unevaluated_page(
@@ -917,10 +889,10 @@ def compile_unevaluated_page(
         Returns:
             The route, compiled component, and compiled page.
         """
-        component, enable_state = compile_unevaluated_page(
-            route, cls.UNCOMPILED_PAGES[route], cls.STATE, style, theme
+        component = compile_unevaluated_page(
+            route, cls.UNCOMPILED_PAGES[route], style, theme
         )
-        return route, component, compile_page(route, component, cls.STATE)
+        return route, component, compile_page(route, component)
 
     @classmethod
     def compile_theme(cls, style: ComponentStyle | None) -> tuple[str, str]:

tests/benchmarks/test_compilation.py

@@ -12,7 +12,7 @@ def import_templates():
 def test_compile_page(evaluated_page: Component, benchmark: BenchmarkFixture):
     import_templates()
 
-    benchmark(lambda: _compile_page(evaluated_page, None))
+    benchmark(lambda: _compile_page(evaluated_page))
 
 
 def test_compile_stateful(evaluated_page: Component, benchmark: BenchmarkFixture):

tests/integration/test_tailwind.py

@@ -46,7 +46,11 @@ def index():
     assets.mkdir(exist_ok=True)
     stylesheet = assets / "test_styles.css"
     stylesheet.write_text(".external { color: rgba(0, 0, 255, 0.5) }")
-    app = rx.App(style={"font_family": "monospace"}, stylesheets=[stylesheet.name])
+    app = rx.App(
+        style={"font_family": "monospace"},
+        stylesheets=[stylesheet.name],
+        enable_state=False,
+    )
     app.add_page(index)
     if not tailwind_version:
         config = rx.config.get_config()

tests/integration/tests_playwright/test_stateless_app.py

@@ -16,7 +16,7 @@ def StatelessApp():
     def index():
         return rx.heading("This is a stateless app")
 
-    app = rx.App()
+    app = rx.App(enable_state=False)
     app.add_page(index)