Skip to content

Commit 767faa1

Browse files
committed
Rename MonadDynamicWriter
1 parent d1e2cb6 commit 767faa1

File tree

5 files changed

+15
-9
lines changed

5 files changed

+15
-9
lines changed

ChangeLog.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
## 0.6.0.0 -- 2019-03-20
44

55
* Deprecate FunctorMaybe in favor of Data.Witherable.Filterable. We still export fmapMaybe, ffilter, etc., but they all rely on Filterable now.
6+
* Rename MonadDynamicWriter to DynamicWriter and add a deprecation for the old name.
67
* Remove many deprecated functions
78
* Add a Num instance for Dynamic
89
* Add matchRequestsWithResponses to make it easier to use Requester with protocols that don't do this matching for you

src/Reflex/DynamicWriter/Base.hs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ mergeDynIncrementalWithMove a = unsafeBuildIncremental (mapM (sample . current)
8888
noLongerMovedMap = Map.fromList $ fmap (, ()) noLongerMoved
8989
in Map.differenceWith (\e _ -> Just $ MapWithMove.nodeInfoSetTo Nothing e) pWithNewVals noLongerMovedMap --TODO: Check if any in the second map are not covered?
9090

91-
-- | A basic implementation of 'MonadDynamicWriter'.
91+
-- | A basic implementation of 'DynamicWriter'.
9292
newtype DynamicWriterT t w m a = DynamicWriterT { unDynamicWriterT :: StateT [Dynamic t w] m a }
9393
deriving (Functor, Applicative, Monad, MonadIO, MonadFix, MonadAsyncException, MonadException) -- The list is kept in reverse order
9494

@@ -116,7 +116,7 @@ runDynamicWriterT (DynamicWriterT a) = do
116116
(result, ws) <- runStateT a []
117117
return (result, mconcat $ reverse ws)
118118

119-
instance (Monad m, Monoid w, Reflex t) => MonadDynamicWriter t w (DynamicWriterT t w m) where
119+
instance (Monad m, Monoid w, Reflex t) => DynamicWriter t w (DynamicWriterT t w m) where
120120
tellDyn w = DynamicWriterT $ modify (w :)
121121

122122
instance MonadReader r m => MonadReader r (DynamicWriterT t w m) where

src/Reflex/DynamicWriter/Class.hs

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
-- | This module defines the 'MonadDynamicWriter' class.
1+
-- | This module defines the 'DynamicWriter' class.
2+
{-# LANGUAGE ConstraintKinds #-}
23
{-# LANGUAGE CPP #-}
34
{-# LANGUAGE FlexibleInstances #-}
45
{-# LANGUAGE FunctionalDependencies #-}
@@ -8,17 +9,21 @@
89
{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
910
#endif
1011
module Reflex.DynamicWriter.Class
11-
( MonadDynamicWriter (..)
12+
( MonadDynamicWriter
13+
, DynamicWriter(..)
1214
) where
1315

1416
import Control.Monad.Reader (ReaderT, lift)
1517
import Reflex.Class (Dynamic)
1618

19+
{-# DEPRECATED MonadDynamicWriter "Use 'DynamicWriter' instead" #-}
20+
type MonadDynamicWriter = DynamicWriter
21+
1722
-- | 'MonadDynamicWriter' efficiently collects 'Dynamic' values using 'tellDyn'
1823
-- and combines them monoidally to provide a 'Dynamic' result.
19-
class (Monad m, Monoid w) => MonadDynamicWriter t w m | m -> t w where
24+
class (Monad m, Monoid w) => DynamicWriter t w m | m -> t w where
2025
tellDyn :: Dynamic t w -> m ()
2126

22-
instance MonadDynamicWriter t w m => MonadDynamicWriter t w (ReaderT r m) where
27+
instance DynamicWriter t w m => DynamicWriter t w (ReaderT r m) where
2328
tellDyn = lift . tellDyn
2429

src/Reflex/EventWriter/Base.hs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ module Reflex.EventWriter.Base
2525
import Reflex.Adjustable.Class
2626
import Reflex.Class
2727
import Reflex.EventWriter.Class (EventWriter, tellEvent)
28-
import Reflex.DynamicWriter.Class (MonadDynamicWriter, tellDyn)
28+
import Reflex.DynamicWriter.Class (DynamicWriter, tellDyn)
2929
import Reflex.Host.Class
3030
import Reflex.PerformEvent.Class
3131
import Reflex.PostBuild.Class
@@ -278,7 +278,7 @@ instance (MonadQuery t q m, Monad m) => MonadQuery t q (EventWriterT t w m) wher
278278
askQueryResult = lift askQueryResult
279279
queryIncremental = lift . queryIncremental
280280

281-
instance MonadDynamicWriter t w m => MonadDynamicWriter t w (EventWriterT t v m) where
281+
instance DynamicWriter t w m => DynamicWriter t w (EventWriterT t v m) where
282282
tellDyn = lift . tellDyn
283283

284284
instance PrimMonad m => PrimMonad (EventWriterT t w m) where

src/Reflex/Query/Base.hs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -340,5 +340,5 @@ instance Requester t m => Requester t (QueryT t q m) where
340340
instance EventWriter t w m => EventWriter t w (QueryT t q m) where
341341
tellEvent = lift . tellEvent
342342

343-
instance MonadDynamicWriter t w m => MonadDynamicWriter t w (QueryT t q m) where
343+
instance DynamicWriter t w m => DynamicWriter t w (QueryT t q m) where
344344
tellDyn = lift . tellDyn

0 commit comments

Comments
 (0)