Skip to content

Commit ab83e25

Browse files
authored
Merge branch 'develop' into clarify-view-docs
2 parents 0acbdbe + d79405c commit ab83e25

File tree

5 files changed

+32
-63
lines changed

5 files changed

+32
-63
lines changed

ChangeLog.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
* Data.WeakBag.traverse and Data.FastWeakBag.traverse have been
66
renamed to Data.WeakBag.traverse_ and Data.FastWeakBag.traverse_
77
respectively.
8+
* Fixes a bug in `Reflex.Patch.MapWithMove.patchThatSortsMapWith` that was producing invalid `PatchMapWithMove`.
89

910
## 0.6.2.4
1011

default.nix

Lines changed: 0 additions & 49 deletions
This file was deleted.

dep/reflex-platform/github.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"owner": "reflex-frp",
33
"repo": "reflex-platform",
4-
"branch": "jailbreakTheselens",
5-
"rev": "4284ed527c96c373538dc7e31776d9a50ca6aa91",
6-
"sha256": "1m1nkxq7ng9wnqbd77xn8d81f2iz8g61y5m0r3gp0gi0q59jm8ay"
4+
"branch": "develop",
5+
"rev": "e7b76dd552a10916c7d8702c11292dac4f4299ea",
6+
"sha256": "0s1183arrwldcs50qhzgnv94v24n9bgq6dfq64wp0a3q2nzyvgwh"
77
}

release.nix

Lines changed: 27 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -17,19 +17,36 @@ let
1717
] ++ lib.optionals (reflex-platform.iosSupport) [
1818
"ghcIosAarch64"
1919
];
20-
hsPkgs = lib.genAttrs compilers (ghc: let
21-
ghc' = reflex-platform.${ghc}.override {
22-
overrides = self: super: {
23-
reflex-dontUseTemplateHaskell = self.callPackage ./. { useTemplateHaskell = false; };
24-
reflex = self.callPackage ./. { useTemplateHaskell = true; };
20+
variations = map (v: "reflex" + v) [
21+
"-dontUseTemplateHaskell"
22+
""
23+
];
24+
compilerPkgs = lib.genAttrs compilers (ghc: let
25+
variationPkgs = lib.genAttrs variations (variation: let
26+
reflex-platform = reflex-platform-fun {
27+
inherit system;
28+
__useTemplateHaskell = variation == "reflex"; # TODO hack
29+
haskellOverlays = [
30+
# Use this package's source for reflex
31+
(self: super: {
32+
_dep = super._dep // {
33+
reflex = builtins.filterSource (path: type: !(builtins.elem (baseNameOf path) [
34+
"release.nix"
35+
".git"
36+
"dist"
37+
])) ./.;
38+
};
39+
})
40+
];
2541
};
26-
};
27-
in {
28-
inherit (ghc') reflex reflex-dontUseTemplateHaskell;
42+
in reflex-platform.${ghc}.reflex);
43+
in variationPkgs // {
44+
cache = reflex-platform.pinBuildInputs "reflex-${system}-${ghc}"
45+
(builtins.attrValues variationPkgs);
2946
});
30-
in hsPkgs // {
47+
in compilerPkgs // {
3148
cache = reflex-platform.pinBuildInputs "reflex-${system}"
32-
(lib.concatLists (map builtins.attrValues (builtins.attrValues hsPkgs)));
49+
(map (a: a.cache) (builtins.attrValues compilerPkgs));
3350
});
3451

3552
metaCache = native-reflex-platform.pinBuildInputs "reflex-everywhere"

src/Reflex/Patch/MapWithMove.hs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ patchThatSortsMapWith cmp m = PatchMapWithMove $ Map.fromList $ catMaybes $ zipW
155155
Just (from, to)
156156
reverseMapping = Map.fromList $ catMaybes $ zipWith f unsorted sorted
157157
g (to, _) (from, _) = if to == from then Nothing else
158-
let Just movingTo = Map.lookup from reverseMapping
158+
let Just movingTo = Map.lookup to reverseMapping
159159
in Just (to, NodeInfo (From_Move from) $ Just movingTo)
160160

161161
-- | Create a 'PatchMapWithMove' that, if applied to the first 'Map' provided,

0 commit comments

Comments
 (0)