Skip to content

Commit d7da654

Browse files
author
Ross MacLeod
committed
fix typo and rename validPatchDMapWithMove' to validationErrorsForPatchDMapWithMove
1 parent 81bff71 commit d7da654

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

src/Reflex/Patch/DMapWithMove.hs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -88,11 +88,11 @@ type To = ComposeMaybe
8888

8989
-- |Test whether a 'PatchDMapWithMove' satisfies its invariants.
9090
validPatchDMapWithMove :: forall k v. (GCompare k, GEq k, GShow k) => DMap k (NodeInfo k v) -> Bool
91-
validPatchDMapWithMove = not . null . validPatchDMapWithMove'
91+
validPatchDMapWithMove = not . null . validationErrorsForPatchDMapWithMove
9292

93-
-- |Test whether a 'PatchDMapWithMove' satisfies its invariants and give reasons why it doesn't.
94-
validPatchDMapWithMove' :: forall k v. (GCompare k, GEq k, GShow k) => DMap k (NodeInfo k v) -> [String]
95-
validPatchDMapWithMove' m =
93+
-- |Enumerate what reasons a 'PatchDMapWithMove' doesn't satisfy its invariants, returning @[]@ if it's valid.
94+
validationErrorsForPatchDMapWithMove :: forall k v. (GCompare k, GEq k, GShow k) => DMap k (NodeInfo k v) -> [String]
95+
validationErrorsForPatchDMapWithMove m =
9696
noSelfMoves `mappend` movesBalanced
9797
where
9898
noSelfMoves = catMaybes . map selfMove . DMap.toAscList $ m
@@ -111,7 +111,7 @@ validPatchDMapWithMove' m =
111111
Just $ "unbalanced move at destination key " <> gshow dst <> " supposedly from " <> gshow src <> " but source key has no move to key"
112112
unbalancedMove (src :=> NodeInfo _ (ComposeMaybe (Just dst))) =
113113
case DMap.lookup dst m of
114-
Nothing -> Just $ " unbalancved move at source key " <> gshow src <> " supposedly going to " <> gshow dst <> " but destination key is not in the patch"
114+
Nothing -> Just $ " unbalanced move at source key " <> gshow src <> " supposedly going to " <> gshow dst <> " but destination key is not in the patch"
115115
Just (NodeInfo (From_Move src') _) ->
116116
if isNothing (src' `geq` src)
117117
then Just $ "unbalanced move at source key " <> gshow src <> " to " <> gshow dst <> " is coming from " <> gshow src' <> " instead"
@@ -287,7 +287,7 @@ unsafePatchDMapWithMove = PatchDMapWithMove
287287
-- otherwise @Left errors@.
288288
patchDMapWithMove :: (GCompare k, GEq k, GShow k) => DMap k (NodeInfo k v) -> Either [String] (PatchDMapWithMove k v)
289289
patchDMapWithMove dm =
290-
case validPatchDMapWithMove' dm of
290+
case validationErrorsForPatchDMapWithMove dm of
291291
[] -> Right $ unsafePatchDMapWithMove dm
292292
errs -> Left errs
293293

0 commit comments

Comments
 (0)