Skip to content

Commit 135ed0d

Browse files
committed
Address PR comments
1 parent 995ae3c commit 135ed0d

File tree

1 file changed

+4
-12
lines changed

1 file changed

+4
-12
lines changed

reframe/core/schedulers/pbs.py

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -205,16 +205,12 @@ def output_ready(job):
205205
# Otherwise, it will return with return code 0 and print information
206206
# only for the jobs it could find.
207207
if completed.returncode in (153, 35):
208-
self.log(f'Return code is {completed.returncode}: '
209-
f'assuming all jobs completed')
208+
self.log(f'Return code is {completed.returncode}')
210209
for job in jobs:
211210
job._state = 'COMPLETED'
212211
if job.cancelled or output_ready(job):
212+
self.log(f'Assuming job {job.jobid} completed')
213213
job._completed = True
214-
else:
215-
self.log(f'Job {job.jobid} output has not been written '
216-
f'back to working directory yet; will poll '
217-
f'again later')
218214

219215
return
220216

@@ -236,15 +232,11 @@ def output_ready(job):
236232

237233
for job in jobs:
238234
if job.jobid not in jobinfo:
239-
self.log(f'Job {job.jobid} not known to scheduler, '
240-
f'assuming job completed')
235+
self.log(f'Job {job.jobid} not known to scheduler')
241236
job._state = 'COMPLETED'
242237
if job.cancelled or output_ready(job):
238+
self.log(f'Assuming job {job.jobid} completed')
243239
job._completed = True
244-
else:
245-
self.log(f'Job {job.jobid} output has not been written '
246-
f'back to working directory yet; will poll '
247-
f'again later')
248240

249241
continue
250242

0 commit comments

Comments
 (0)