Skip to content

Commit 143c48a

Browse files
committed
Address PR remarks
1 parent bf3b694 commit 143c48a

File tree

2 files changed

+13
-4
lines changed

2 files changed

+13
-4
lines changed

reframe/core/logging.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -175,8 +175,8 @@ def formatTime(self, record, datefmt=None):
175175

176176
def format(self, record):
177177
datefmt = self.datefmt or self.default_time_format
178-
if record.check_job_unix_completion_time is not None:
179-
ct = self.converter(record.check_job_unix_completion_time)
178+
if record.check_job_completion_time_unix is not None:
179+
ct = self.converter(record.check_job_completion_time_unix)
180180
record.check_job_completion_time = _format_time_rfc3339(
181181
ct, datefmt
182182
)
@@ -419,7 +419,7 @@ def __init__(self, logger=None, check=None):
419419
'check_name': 'reframe',
420420
'check_jobid': '-1',
421421
'check_job_completion_time': None,
422-
'check_job_unix_completion_time': None,
422+
'check_job_completion_time_unix': None,
423423
'check_info': 'reframe',
424424
'check_system': None,
425425
'check_partition': None,
@@ -481,7 +481,7 @@ def _update_check_extras(self):
481481
self.extra['check_jobid'] = self.check.job.jobid
482482
if self.check.job.completion_time:
483483
ct = self.check.job.completion_time
484-
self.extra['check_job_unix_completion_time'] = ct
484+
self.extra['check_job_completion_time_unix'] = ct
485485

486486
def log_performance(self, level, tag, value, ref,
487487
low_thres, upper_thres, unit=None, *, msg=None):

unittests/test_cli.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -473,6 +473,15 @@ def test_verbosity(self):
473473
assert 'Traceback' not in stderr
474474
assert 0 == returncode
475475

476+
def test_verbosity_with_check(self):
477+
self.more_options = ['-vvvvv']
478+
self.checkpath = ['unittests/resources/checks/hellocheck.py']
479+
returncode, stdout, stderr = self._run_reframe()
480+
assert '' != stdout
481+
assert 'Traceback' not in stdout
482+
assert 'Traceback' not in stderr
483+
assert 0 == returncode
484+
476485
@fixtures.switch_to_user_runtime
477486
def test_unload_module(self):
478487
# This test is mostly for ensuring coverage. `_run_reframe()` restores

0 commit comments

Comments
 (0)