Skip to content

Commit 1e47b20

Browse files
committed
Do not use CLI defaults for options that are backed by a config. option
1 parent 5d8e222 commit 1e47b20

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

reframe/frontend/cli.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -285,7 +285,7 @@ def main():
285285
envvar='RFM_STAGE_DIR', configvar='systems/stagedir'
286286
)
287287
output_options.add_argument(
288-
'--save-log-files', action='store_true', default=False,
288+
'--save-log-files', action='store_true',
289289
help='Save ReFrame log files to the output directory',
290290
envvar='RFM_SAVE_LOG_FILES', configvar='general/save_log_files'
291291
)
@@ -474,12 +474,12 @@ def main():
474474
# Environment options
475475
env_options.add_argument(
476476
'-M', '--map-module', action='append', metavar='MAPPING',
477-
dest='module_mappings', default=[],
477+
dest='module_mappings',
478478
help='Add a module mapping',
479479
envvar='RFM_MODULE_MAPPINGS ,', configvar='general/module_mappings'
480480
)
481481
env_options.add_argument(
482-
'-m', '--module', action='append', default=[],
482+
'-m', '--module', action='append',
483483
metavar='MOD', dest='user_modules',
484484
help='Load module MOD before running any regression check',
485485
envvar='RFM_USER_MODULES ,', configvar='general/user_modules'
@@ -501,13 +501,13 @@ def main():
501501
envvar='RFM_NON_DEFAULT_CRAYPE', configvar='general/non_default_craype'
502502
)
503503
env_options.add_argument(
504-
'--purge-env', action='store_true', dest='purge_env', default=False,
504+
'--purge-env', action='store_true', dest='purge_env',
505505
help='Unload all modules before running any regression check',
506506
envvar='RFM_PURGE_ENVIRONMENT', configvar='general/purge_environment'
507507
)
508508
env_options.add_argument(
509509
'-u', '--unload-module', action='append', metavar='MOD',
510-
dest='unload_modules', default=[],
510+
dest='unload_modules',
511511
help='Unload module MOD before running any regression check',
512512
envvar='RFM_UNLOAD_MODULES ,', configvar='general/unload_modules'
513513
)

0 commit comments

Comments
 (0)