Address PR comments

Author: ekouts

reframe/frontend/executors/policies.py

@@ -168,7 +168,9 @@ def __init__(self):
         self.task_listeners.append(self)
 
     def _remove_from_running(self, task):
-        getlogger().debug('removing task from running: %s' % task.check.info())
+        getlogger().debug(
+            'removing task from running list: %s' % task.check.info()
+        )
         try:
             self._running_tasks.remove(task)
         except ValueError:
@@ -179,7 +181,9 @@ def _remove_from_running(self, task):
             self._running_tasks_counts[partname] -= 1
 
     def _remove_from_waiting(self, task):
-        getlogger().debug('removing task from waiting: %s' % task.check.info())
+        getlogger().debug(
+            'removing task from waiting list: %s' % task.check.info()
+        )
         try:
             self._waiting_tasks.remove(task)
         except ValueError:

unittests/resources/checks_unlisted/deps_complex.py

@@ -164,16 +164,19 @@ def prepend_output(self, T1):
         with open(os.path.join(T1().stagedir, 'out.txt')) as fp:
             self._count += int(fp.read())
 
-    # Make this test fail on purpose
     @rfm.run_after('setup')
     def fail(self):
+        '''Make this test fail on purpose'''
+
         raise Exception
 
 
-# This tests fails because of T8. It is added to make sure that
-# all tests are accounted for in the summary.
 @rfm.simple_test
 class T9(BaseTest):
+    '''This tests fails because of T8. It is added to make sure that
+    all tests are accounted for in the summary.
+    '''
+
     def __init__(self):
         super().__init__()
         self.depends_on('T8')

unittests/test_policies.py

@@ -225,9 +225,9 @@ def test_dependencies(self):
         self.checks = self.loader.load_all()
         self.runall(self.checks, sort=True)
 
+        self.assertRunall()
         stats = self.runner.stats
         assert stats.num_cases(0) == 10
-        self.assertRunall()
         assert len(stats.failures()) == 4
         for tf in stats.failures():
             check = tf.testcase.check