Merge pull request #1424 from difey/patch-1

[bugfix] Convert Syslog handler port parameter into integer

Author: Vasileios Karakasis

reframe/core/logging.py

@@ -222,7 +222,12 @@ def _create_syslog_handler(site_config, config_prefix):
     except ValueError:
         pass
     else:
-        address = (host, port)
+        try:
+            address = (host, int(port))
+        except ValueError:
+            raise ConfigError(
+                f'syslog address port not an integer: {port!r}'
+            ) from None
 
     facility = site_config.get(f'{config_prefix}/facility')
     try:

unittests/test_logging.py

@@ -337,7 +337,7 @@ def test_syslog_handler(temp_runtime):
     if platform.system() == 'Linux':
         addr = '/dev/log'
     elif platform.system() == 'Darwin':
-        addr = '/dev/run/syslog'
+        addr = '/var/run/syslog'
     else:
         pytest.skip('unknown system platform')
 
@@ -351,6 +351,20 @@ def test_syslog_handler(temp_runtime):
     rlog.getlogger().info('foo')
 
 
+def test_syslog_handler_tcp_port_noint(temp_runtime):
+    runtime = temp_runtime({
+        'level': 'info',
+        'handlers': [{
+            'type': 'syslog',
+            'address': 'foo.server.org:bar',
+        }],
+        'handlers_perflog': []
+    })
+    next(runtime)
+    with pytest.raises(ConfigError, match="not an integer: 'bar'"):
+        rlog.configure_logging(rt.runtime().site_config)
+
+
 def test_global_noconfig():
     # This is to test the case when no configuration is set, but since the
     # order the unit tests are invoked is arbitrary, we emulate the