Add CLI unit tests

Author: Vasileios Karakasis

reframe/core/exceptions.py

@@ -154,6 +154,10 @@ class ContainerError(ReframeError):
     '''Raised when a container platform is not configured properly.'''
 
 
+class CommandLineError(ReframeError):
+    '''Raised when an error in command-line arguments occurs.'''
+
+
 class BuildError(ReframeError):
     '''Raised when a build fails.'''
 

reframe/frontend/cli.py

@@ -1041,10 +1041,15 @@ def _case_failed(t):
             )
 
         if options.repeat is not None:
-            num_repeats = int(options.repeat)
-            if num_repeats <= 0:
-                raise ValueError('the number of repetitions '
-                                 'must be a positive integer')
+            try:
+                num_repeats = int(options.repeat)
+                if num_repeats <= 0:
+                    raise ValueError
+            except ValueError:
+                raise errors.CommandLineError(
+                    "argument to '--repeat' option must be "
+                    "a non-negative integer"
+                ) from None
 
             testcases = repeat_tests(testcases, num_repeats)
             testcases_all = testcases
@@ -1241,7 +1246,7 @@ def module_unuse(*paths):
             errmsg = "invalid option for --flex-alloc-nodes: '{0}'"
             sched_flex_alloc_nodes = int(options.flex_alloc_nodes)
             if sched_flex_alloc_nodes <= 0:
-                raise errors.ConfigError(
+                raise errors.CommandLineError(
                     errmsg.format(options.flex_alloc_nodes)
                 )
         except ValueError:
@@ -1250,7 +1255,7 @@ def module_unuse(*paths):
         exec_policy.sched_flex_alloc_nodes = sched_flex_alloc_nodes
         exec_policy.sched_options = parsed_job_options
         if options.maxfail < 0:
-            raise errors.ConfigError(
+            raise errors.CommandLineError(
                 f'--maxfail should be a non-negative integer: '
                 f'{options.maxfail!r}'
             )

unittests/test_cli.py

@@ -808,6 +808,42 @@ def test_maxfail_negative(run_reframe):
     assert returncode == 1
 
 
+def test_repeat_option(run_reframe):
+    returncode, stdout, stderr = run_reframe(
+        more_options=['--repeat', '2', '-n', 'HelloTest'],
+        checkpath=['unittests/resources/checks/hellocheck.py']
+    )
+    assert 'Traceback' not in stdout
+    assert 'Traceback' not in stderr
+    assert ('Ran 2/2 test case(s) from 2 check(s) '
+            '(0 failure(s), 0 skipped)') in stdout
+    assert returncode == 0
+
+
+def test_repeat_invalid_option(run_reframe):
+    returncode, stdout, stderr = run_reframe(
+        more_options=['--repeat', 'foo'],
+        checkpath=['unittests/resources/checks/hellocheck.py']
+    )
+    errmsg = "argument to '--repeat' option must be a non-negative integer"
+    assert 'Traceback' not in stdout
+    assert 'Traceback' not in stderr
+    assert errmsg in stdout
+    assert returncode == 1
+
+
+def test_repeat_negative(run_reframe):
+    returncode, stdout, stderr = run_reframe(
+        more_options=['--repeat', 'foo'],
+        checkpath=['unittests/resources/checks/hellocheck.py']
+    )
+    errmsg = "argument to '--repeat' option must be a non-negative integer"
+    assert 'Traceback' not in stdout
+    assert 'Traceback' not in stderr
+    assert errmsg in stdout
+    assert returncode == 1
+
+
 def test_detect_host_topology(run_reframe):
     from reframe.utility.cpuinfo import cpuinfo