Skip to content

Commit 5793df1

Browse files
author
Vasileios Karakasis
committed
Address PR comments
1 parent 2c794d1 commit 5793df1

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

docs/tutorial_advanced.rst

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ Let's inspect the build script generated by ReFrame:
161161
162162
trap _onerror ERR
163163
164-
make -j 1 CPPFLAGS="-DELEM_TYPE=float" CC=cc CXX=CC
164+
make -j 1 CC="cc" CXX="CC" FC="ftn" NVCC="nvcc" CPPFLAGS="-DELEM_TYPE=float"
165165
166166
167167
The compiler variables (``CC``, ``CXX`` etc.) are set based on the corresponding values specified in the `configuration <config_reference.html#environment-configuration>`__ of the current environment.
@@ -175,7 +175,7 @@ In this case, ``make`` will be invoked as follows:
175175

176176
.. code::
177177
178-
make -j 1 CPPFLAGS="-DELEM_TYPE=float" CC=cc CXX=CC
178+
make -j 1 CPPFLAGS="-DELEM_TYPE=float"
179179
180180
Notice that the ``-j 1`` option is always generated.
181181
We can increase the build concurrency by setting the :attr:`~reframe.core.buildsystems.Make.max_concurrency` attribute.
@@ -682,7 +682,7 @@ The test will verify that all the nodes print the expected host name:
682682

683683
The first thing to notice in this test is that :attr:`~reframe.core.pipeline.RegressionTest.num_tasks` is set to zero as default, which is a requirement for flexible tests.
684684
However, with flexible tests, this value is updated right after the job completes to the actual number of tasks that were used.
685-
Consequenly, this allows the sanity function of the tests to assert that the number host names printed matches :attr:`~reframe.core.pipeline.RegressionTest.num_tasks`.
685+
Consequently, this allows the sanity function of the test to assert that the number host names printed matches :attr:`~reframe.core.pipeline.RegressionTest.num_tasks`.
686686

687687
.. |--flex-alloc-nodes| replace:: :attr:`--flex-alloc-nodes`
688688
.. _--flex-alloc-nodes: manpage.html#cmdoption-flex-alloc-nodes

tutorials/basics/stream/stream2.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99

1010
@rfm.simple_test
11-
class StreamWithRefTest(rfm.RegressionTest):
11+
class StreamAltTest(rfm.RegressionTest):
1212
valid_systems = ['*']
1313
valid_prog_environs = ['gnu']
1414
prebuild_cmds = [

0 commit comments

Comments
 (0)