Fine tune PR

Author: Vasileios Karakasis

reframe/core/buildsystems.py

@@ -846,12 +846,13 @@ class Spack(BuildSystem):
     install_opts = variable(typ.List[str], value=[])
 
     def __init__(self):
-        self._rfm_spack_env = False
+        # Set to True if the environment was auto-generated
+        self._auto_env = False
 
     def emit_build_commands(self, environ):
         ret = self._env_activate_cmds()
 
-        if self._rfm_spack_env:
+        if self._auto_env:
             install_tree = self.install_tree or 'opt/spack'
             ret.append(f'spack config add '
                        f'"config:install_tree:root:{install_tree}"')
@@ -872,7 +873,7 @@ def _env_activate_cmds(self):
         if not self.environment:
             self.environment = 'rfm_spack_env'
             cmds.append(f'spack env create -d {self.environment}')
-            self._rfm_spack_env = True
+            self._auto_env = True
 
         cmds.append(f'spack env activate -V -d {self.environment}')
         return cmds

unittests/test_buildsystems.py

@@ -289,6 +289,9 @@ def test_spack_no_env(environ, tmp_path):
             f'spack install'
         ]
 
+    assert build_system.environment == 'rfm_spack_env'
+
+
 def test_easybuild(environ, tmp_path):
     build_system = bs.EasyBuild()
     build_system.easyconfigs = ['ec1.eb', 'ec2.eb']