Address PR comments

Author: Theofilos Manitaras

cscs-checks/prgenv/openacc_checks.py

@@ -5,27 +5,26 @@
 @rfm.parameterized_test([1], [2])
 class OpenACCFortranCheck(rfm.RegressionTest):
     def __init__(self, num_tasks):
+        super().__init__()
         if num_tasks == 1:
             self.name = 'openacc_fortran_check'
         else:
             self.name = 'openacc_mpi_fortran_check'
 
-        super().__init__()
+        self.descr = self.name
         self.valid_systems = ['daint:gpu', 'dom:gpu', 'kesch:cn']
         self.valid_prog_environs = ['PrgEnv-cray', 'PrgEnv-pgi']
-        if self.current_system.name in ['daint', 'dom']:
-            self.modules = ['craype-accel-nvidia60']
-            self._pgi_flags = ['-acc', '-ta=tesla:cc60']
-        elif self.current_system.name in ['kesch']:
-            self.modules = ['craype-accel-nvidia35']
-            self._pgi_flags = ['-acc', '-ta=tesla:cc35']
-
         self.num_tasks = num_tasks
         if self.num_tasks == 1:
             self.sourcepath = 'vecAdd_openacc.f90'
         else:
             self.sourcepath = 'vecAdd_openacc_mpi.f90'
 
+        if self.current_system.name in ['daint', 'dom']:
+            self.modules = ['craype-accel-nvidia60']
+        elif self.current_system.name == 'kesch':
+            self.modules = ['craype-accel-nvidia35']
+
         self.build_system = 'SingleSource'
         self.num_gpus_per_node = 1
         self.executable = self.name
@@ -41,6 +40,9 @@ def setup(self, partition, environ, **job_opts):
         if environ.name == 'PrgEnv-cray':
             self.build_system.fflags = ['-hacc', '-hnoomp']
         elif environ.name == 'PrgEnv-pgi':
-            self.build_system.fflags = self._pgi_flags
+            if self.current_system.name in ['daint', 'dom']:
+                self.build_system.fflags = ['-acc', '-ta=tesla:cc60']
+            else:
+                self.build_system.fflags = ['-acc', '-ta=tesla:cc35']
 
         super().setup(partition, environ, **job_opts)

cscs-checks/prgenv/ulimit_check.py

@@ -12,7 +12,6 @@ def __init__(self):
         self.valid_prog_environs = ['PrgEnv-cray',  'PrgEnv-gnu',
                                     'PrgEnv-intel', 'PrgEnv-pgi']
         self.sourcepath = 'ulimit.c'
-        self.build_system = 'SingleSource'
         self.sanity_patterns = sn.all([
             sn.assert_found(r'The soft limit is unlimited', self.stdout),
             sn.assert_found(r'The hard limit is unlimited', self.stdout),