Skip to content

Commit 613856a

Browse files
authored
Merge pull request #2852 from vkarak/bugfix/logging-perf-thres
[bugfix] Fix log record attribute names of performance thresholds
2 parents 7255aef + 856fad0 commit 613856a

File tree

4 files changed

+9
-9
lines changed

4 files changed

+9
-9
lines changed

docs/config_reference.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1065,7 +1065,7 @@ All logging handlers share the following set of common attributes:
10651065
``%(check_perf_lower_thres)s``, The lower threshold of the logged performance variable.
10661066
``%(check_perf_ref)s``, The reference value of the logged performance variable.
10671067
``%(check_perf_unit)s``, The measurement unit of the logged performance variable.
1068-
``%(check_perf_upper)s``, The upper thresholds of the logged performance variable.
1068+
``%(check_perf_upper_thres)s``, The upper threshold of the logged performance variable.
10691069
``%(check_perf_value)s``, The actual value of the logged performance variable.
10701070
``%(check_perf_var)s``, The name of the logged performance variable.
10711071

reframe/core/logging.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -280,8 +280,8 @@ def _format_perf(self, perfvars):
280280
'check_perf_value': val,
281281
'check_perf_unit': unit,
282282
'check_perf_ref': ref,
283-
'check_perf_lower': lower,
284-
'check_perf_upper': upper
283+
'check_perf_lower_thres': lower,
284+
'check_perf_upper_thres': upper
285285
}
286286
try:
287287
chunks.append(self.__fmtperf % record)

reframe/core/settings.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,8 @@
6262
),
6363
'format_perfvars': (
6464
'%(check_perf_value)s,%(check_perf_unit)s,'
65-
'%(check_perf_ref)s,%(check_perf_lower)s,'
66-
'%(check_perf_upper)s,'
65+
'%(check_perf_ref)s,%(check_perf_lower_thres)s,'
66+
'%(check_perf_upper_thres)s,'
6767
),
6868
'append': True
6969
}

unittests/test_policies.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1099,8 +1099,8 @@ def test_perf_logging(make_runner, make_exec_ctx, perf_test,
10991099
),
11001100
perffmt=(
11011101
'%(check_perf_value)s,%(check_perf_unit)s,'
1102-
'%(check_perf_ref)s,%(check_perf_lower)s,'
1103-
'%(check_perf_upper)s,'
1102+
'%(check_perf_ref)s,%(check_perf_lower_thres)s,'
1103+
'%(check_perf_upper_thres)s,'
11041104
)
11051105
)
11061106
)
@@ -1277,8 +1277,8 @@ def test_perf_logging_lazy(make_runner, make_exec_ctx, lazy_perf_test,
12771277
),
12781278
perffmt=(
12791279
'%(check_perf_value)s,%(check_perf_unit)s,'
1280-
'%(check_perf_ref)s,%(check_perf_lower)s,'
1281-
'%(check_perf_upper)s,'
1280+
'%(check_perf_ref)s,%(check_perf_lower_thres)s,'
1281+
'%(check_perf_upper_thres)s,'
12821282
)
12831283
)
12841284
)

0 commit comments

Comments
 (0)