Merge branch 'master' into bugfix/syslog-handler-crash

Author: Vasileios Karakasis

cscs-checks/libraries/magma/magma_checks.py

@@ -40,80 +40,82 @@ def __init__(self, subtest):
                 },
             }
         elif subtest == 'zgemm':
+            self.executable_opts = ['--range 1088:3136:1024']
             self.perf_patterns = {
-                'magma': sn.extractsingle(r'MAGMA GFlops: (?P<magma_gflops>\S+)',
-                                          self.stdout, 'magma_gflops', float),
+                'magma': sn.extractsingle(
+                    r'MAGMA GFlops: (?P<magma_gflops>\S+)',
+                    self.stdout, 'magma_gflops', float, 2
+                ),
                 'cublas': sn.extractsingle(
                     r'cuBLAS GFlops: (?P<cublas_gflops>\S+)', self.stdout,
-                    'cublas_gflops', float),
-                'cpu': sn.extractsingle(r'CPU GFlops: (?P<cpu_gflops>\S+)',
-                                        self.stdout, 'cpu_gflops', float)
+                    'cublas_gflops', float, 2)
             }
             self.reference = {
                 'daint:gpu': {
-                    'magma':  (3344, -0.05, None, 'Gflop/s'),
-                    'cublas': (3709, -0.05, None, 'Gflop/s'),
-                    'cpu':    (42.8, -0.27, None, 'Gflop/s'),
+                    'magma':  (3692.65, -0.05, None, 'Gflop/s'),
+                    'cublas': (4269.31, -0.09, None, 'Gflop/s'),
                 },
                 'dom:gpu': {
-                    'magma':  (3344, -0.05, None, 'Gflop/s'),
-                    'cublas': (3709, -0.05, None, 'Gflop/s'),
-                    'cpu':    (42.8, -0.27, None, 'Gflop/s'),
+                    'magma':  (3692.65, -0.05, None, 'Gflop/s'),
+                    'cublas': (4269.31, -0.09, None, 'Gflop/s'),
+                },
+                '*': {
+                    'magma':  (0, None, None, 'Gflop/s'),
+                    'cublas': (0, None, None, 'Gflop/s'),
                 },
             }
         elif subtest == 'zsymmetrize':
             self.perf_patterns = {
-                'cpu_perf': sn.extractsingle(r'CPU performance: (\S+)',
-                                             self.stdout, 1, float),
                 'gpu_perf': sn.extractsingle(r'GPU performance: (\S+)',
                                              self.stdout, 1, float),
             }
             self.reference = {
                 'daint:gpu': {
-                    'cpu_perf': (0.91, -0.05, None, 'GB/s'),
                     'gpu_perf': (158.3, -0.05, None, 'GB/s'),
                 },
                 'dom:gpu': {
-                    'cpu_perf': (0.91, -0.05, None, 'GB/s'),
                     'gpu_perf': (158.3, -0.05, None, 'GB/s'),
                 },
+                '*': {
+                    'gpu_perf': (0, None, None, 'GB/s'),
+                },
             }
         elif subtest == 'ztranspose':
             self.perf_patterns = {
-                'cpu_perf':
-                    sn.extractsingle(r'CPU performance: (?P<cpu_performance>\S+)',
-                                     self.stdout, 'cpu_performance', float),
                 'gpu_perf':
-                    sn.extractsingle(r'GPU performance: (?P<gpu_performance>\S+)',
-                                     self.stdout, 'gpu_performance', float)
+                    sn.extractsingle(
+                        r'GPU performance: (?P<gpu_performance>\S+)',
+                        self.stdout, 'gpu_performance', float
+                    )
             }
             self.reference = {
                 'daint:gpu': {
-                    'cpu_perf': (1.51, -0.05, None, 'GB/s'),
                     'gpu_perf': (498.2, -0.05, None, 'GB/s'),
                 },
                 'dom:gpu': {
-                    'cpu_perf': (1.51, -0.05, None, 'GB/s'),
                     'gpu_perf': (498.2, -0.05, None, 'GB/s'),
                 },
+                '*': {
+                    'gpu_perf': (0, None, None, 'GB/s'),
+                },
             }
         elif subtest == 'zunmbr':
             # This test fails to compile with Magma 2.4
             self.perf_patterns = {
-                'cpu_perf':
-                    sn.extractsingle(r'CPU performance: (?P<cpu_performance>\S+)',
-                                     self.stdout, 'cpu_performance', float),
                 'gpu_perf':
-                    sn.extractsingle(r'GPU performance: (?P<gpu_performance>\S+)',
-                                     self.stdout, 'gpu_performance', float)
+                    sn.extractsingle(
+                        r'GPU performance: (?P<gpu_performance>\S+)',
+                        self.stdout, 'gpu_performance', float
+                    )
             }
             self.reference = {
                 'daint:gpu': {
-                    'cpu_perf': (36.6, -0.05, None, 'Gflop/s'),
                     'gpu_perf': (254.7, -0.05, None, 'Gflop/s'),
                 },
                 'dom:gpu': {
-                    'cpu_perf': (36.6, -0.05, None, 'Gflop/s'),
                     'gpu_perf': (254.7, -0.05, None, 'Gflop/s'),
                 },
+                '*': {
+                    'gpu_perf': (0, None, None, 'Gflop/s'),
+                },
             }

cscs-checks/libraries/magma/src/patch.txt

@@ -67,16 +67,6 @@ diff -Naur src/testing_zgemm.cpp src_patched/testing_zgemm.cpp
 
      // Allow 3*eps; complex needs 2*sqrt(2) factor; see Higham, 2002, sec. 3.6.
      double eps = lapackf77_dlamch("E");
-@@ -87,7 +88,8 @@
-                 g_platform_str, g_platform_str );
-     #endif
-     printf("%%========================================================================================================\n");
--    for( int itest = 0; itest < opts.ntest; ++itest ) {
-+//ajajajaj    for( int itest = 0; itest < opts.ntest; ++itest ) {
-+    for( int itest = 0; itest < opts.ntest; itest+=100 ) {
-         for( int iter = 0; iter < opts.niter; ++iter ) {
-             M = opts.msize[itest];
-             N = opts.nsize[itest];
 @@ -220,6 +222,9 @@
                             cpu_perf,    1000.*cpu_time,
                             magma_error, dev_error,

reframe/core/buildsystems.py

@@ -6,7 +6,7 @@
 from reframe.core.exceptions import BuildSystemError
 
 
-class BuildSystem:
+class BuildSystem(abc.ABC):
     """The abstract base class of any build system.
 
     Concrete build systems inherit from this class and must override the

reframe/frontend/executors/__init__.py

@@ -212,7 +212,7 @@ def abort(self, cause=None):
             self.fail((type(exc), exc, None))
 
 
-class TaskEventListener:
+class TaskEventListener(abc.ABC):
     @abc.abstractmethod
     def on_task_run(self, task):
         """Called whenever the run() method of a RegressionTask is called."""
@@ -320,7 +320,7 @@ def print_separator(check, prefix):
         self._policy.exit()
 
 
-class ExecutionPolicy:
+class ExecutionPolicy(abc.ABC):
     """Base abstract class for execution policies.
 
     An execution policy implements the regression check pipeline."""
@@ -369,7 +369,3 @@ def runcase(self, case):
 
         if self.force_local:
             case.check.local = True
-
-    @abc.abstractmethod
-    def getstats(self):
-        """Return test case statistics of the run."""

reframe/utility/versioning.py

@@ -67,7 +67,7 @@ def __str__(self):
         return base + '-dev%s' % self._dev_number
 
 
-class _ValidatorImpl:
+class _ValidatorImpl(abc.ABC):
     """Abstract base class for the validation of version ranges."""
     @abc.abstractmethod
     def validate(version):
@@ -81,6 +81,7 @@ class _IntervalValidator(_ValidatorImpl):
     ``validate`` returns ``True`` if a given version string is inside
     the interval including the endpoints.
     """
+
     def __init__(self, condition):
         try:
             min_version_str, max_version_str = condition.split('..')
@@ -108,6 +109,7 @@ class _RelationalValidator(_ValidatorImpl):
     ``<bool_operator><version>``, and its method ``validate`` returns
     ``True`` if a given version string satisfies the relation.
     """
+
     def __init__(self, condition):
         self._op_actions = {
             ">":  lambda x, y: x > y,

unittests/test_buildsystems.py

@@ -6,7 +6,7 @@
 from reframe.core.exceptions import BuildSystemError
 
 
-class _BuildSystemTest:
+class _BuildSystemTest(abc.ABC):
     @abc.abstractmethod
     def create_build_system(self):
         pass

unittests/test_modules.py

@@ -10,7 +10,7 @@
 from unittests.fixtures import TEST_MODULES
 
 
-class _TestModulesSystem:
+class _TestModulesSystem(abc.ABC):
     def setUp(self):
         self.environ_save = EnvironmentSnapshot()
         self.modules_system.searchpath_add(TEST_MODULES)

unittests/test_schedulers.py

@@ -18,7 +18,7 @@
 from reframe.core.schedulers.slurm import SlurmNode
 
 
-class _TestJob:
+class _TestJob(abc.ABC):
     def setUp(self):
         self.workdir = tempfile.mkdtemp(dir='unittests')
         self.testjob = self.job_type(
@@ -71,7 +71,6 @@ def setup_user(self, msg=None):
 
         self.testjob.options += partition.access
 
-    @abc.abstractmethod
     def assertScriptSanity(self, script_file):
         """Assert the sanity of the produced script file."""
         with open(self.testjob.script_filename) as fp: