Skip to content

Commit 771a3bb

Browse files
committed
Address PR comments
1 parent e999408 commit 771a3bb

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

cscs-checks/microbenchmarks/stream/stream.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,8 +111,8 @@ def __init__(self):
111111
self.tags = {'production', 'craype'}
112112
self.maintainers = ['RS', 'SK']
113113

114-
@rfm.run_before('compile')
115-
def prepare_compile(self):
114+
@rfm.run_after('setup')
115+
def prepare_test(self):
116116
self.num_cpus_per_task = self.stream_cpus_per_task.get(
117117
self.current_partition.fullname, 1)
118118
self.variables['OMP_NUM_THREADS'] = str(self.num_cpus_per_task)

cscs-checks/prgenv/affinity_check.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@ def __init__(self, variant):
2323
self.maintainers = ['RS', 'SK']
2424
self.tags = {'production', 'scs', 'maintenance', 'craype'}
2525

26-
@rfm.run_after('setup')
27-
def prepare_test(self):
26+
@rfm.run_before('sanity')
27+
def set_sanity(self):
2828

2929
def parse_cpus(x):
3030
return sorted([int(xi) for xi in x.split()])
@@ -48,8 +48,6 @@ def parse_cpus(x):
4848
re_aff_ranks, self.cases[self.variant][ref_key],
4949
'rank', int)
5050

51-
self.use_multithreading = self.cases[self.variant]['multithreading']
52-
5351
# Ranks and threads can be extracted into lists in order to compare
5452
# them since the affinity programm prints them in ascending order.
5553
self.sanity_patterns = sn.all([
@@ -58,6 +56,10 @@ def parse_cpus(x):
5856
sn.assert_eq(sn.sorted(self.aff_cores), sn.sorted(self.ref_cores))
5957
])
6058

59+
@rfm.run_before('run')
60+
def set_multithreading(self):
61+
self.use_multithreading = self.cases[self.variant]['multithreading']
62+
6163

6264
@rfm.parameterized_test(['omp_bind_threads'],
6365
['omp_bind_threads_nomultithread'],

0 commit comments

Comments
 (0)