Address PR comments

Author: Theofilos Manitaras

reframe/utility/sanity.py

@@ -488,7 +488,7 @@ def assert_reference(val, ref, lower_thres=None, upper_thres=None, msg=None):
 
     if upper_thres is not None:
         try:
-            evaluate(assert_bounded(upper_thres, 0, None))
+            evaluate(assert_bounded(upper_thres, None, None))
         except SanityError:
             raise SanityError('invalid high threshold value: %s' % upper_thres)
 

unittests/test_sanity_functions.py

@@ -340,6 +340,10 @@ def test_assert_reference(self):
         self.assertTrue(sn.assert_reference(-0.9, -1, upper_thres=0.1))
         self.assertTrue(sn.assert_reference(-0.9, -1))
 
+        # Check upper threshold values greater than 1
+        self.assertTrue(sn.assert_reference(30.0, 10.0, None, 3.0))
+        self.assertTrue(sn.assert_reference(-50.0, -20.0, None, 2.0))
+
         self.assertRaisesRegex(
             SanityError,
             '0\.5 is beyond reference value 1 \(l=0\.8, u=1\.1\)',
@@ -378,10 +382,6 @@ def test_assert_reference(self):
                                'invalid low threshold value: 1\.2',
                                evaluate, sn.assert_reference(0.9, 1, 1.2, 0.1))
 
-        # Check upper threshold values greater than 1
-        self.assertTrue(sn.assert_reference(30.0, 10.0, None, 3.0))
-        self.assertTrue(sn.assert_reference(50.0, 20.0, None, 2.0))
-
     def _write_tempfile(self):
         ret = None
         with NamedTemporaryFile('wt', delete=False) as fp: