Skip to content

Commit a2e18c1

Browse files
author
Vasileios Karakasis
committed
Address PR comments
1 parent 64c42cf commit a2e18c1

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

docs/tutorial_fixtures.rst

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ Each fixture is associated with a scope.
3030
This practically indicates at which level a fixture is shared with other tests.
3131
There are four fixture scopes, which are listed below in decreasing order of generality:
3232

33-
- ``session``: A fixture with this scope will be executed once per a ReFrame run session and will be shared across the whole run.
33+
- ``session``: A fixture with this scope will be executed once per ReFrame run session and will be shared across the whole run.
3434
- ``partition``: A fixture with this scope will be executed once per partition and will be shared across all tests that run in that partition.
3535
- ``environment``: A fixture with this scope will be executed once per partition and environment combination and will be shared across all tests that run with this partition and environment combination.
3636
- ``test``: A fixture with this scope is private to the test and will be executed for each test case.
@@ -57,7 +57,7 @@ Let's inspect now the :class:`build_osu_benchmarks` fixture:
5757
It is obvious that it is a normal ReFrame test except that it does not need to be decorated with the :func:`@simple_test <reframe.core.decorators.simple_test>` decorator.
5858
This means that the test will only be executed if it is a fixture of another test.
5959
If it was decorated, it would be executed both as a standalone test and as a fixture of another test.
60-
Another detail is that this test does dot define the :attr:`~reframe.core.pipeline.RegressionTest.valid_systems` and :attr:`~reframe.core.pipeline.RegressionTest.valid_prog_environs` variables.
60+
Another detail is that this test does not define the :attr:`~reframe.core.pipeline.RegressionTest.valid_systems` and :attr:`~reframe.core.pipeline.RegressionTest.valid_prog_environs` variables.
6161
Fixtures inherit those variables from the test that owns them depending on the scope.
6262

6363
Similarly to :class:`OSUBenchmarkTestBase`, this test uses a fixture that fetches the OSU benchmarks sources.
@@ -78,7 +78,7 @@ Let's inspect the last fixture, the :class:`fetch_osu_benchmarks`:
7878

7979
There is nothing special to this test -- it is just an ordinary test -- except that we force it to execute locally by setting its :attr:`~reframe.core.pipeline.RegressionTest.local` variable.
8080
The reason for that is that a fixture at session scope can execute with any partition/environment combination, so ReFrame could have to spawn a job in case it has chosen a remote partition to launch this fixture on.
81-
For this reason, we simply force it execute locally regardless of the chosen partition.
81+
For this reason, we simply force it to execute locally regardless of the chosen partition.
8282

8383
It is now time to run the new tests, but let us first list them:
8484

@@ -126,7 +126,7 @@ The following figure shows the generated fixtures as well as their conceptual de
126126

127127
:sub:`Expanded fixtures and dependencies for the OSU benchmarks example.`
128128

129-
Notice how the :class:`build_osu_benchmarks` fixture is populated three times, for each partition and environment combination, and the :class:`fetch_osu_benchmarks` is generated only once.
129+
Notice how the :class:`build_osu_benchmarks` fixture is populated three times, once for each partition and environment combination, and the :class:`fetch_osu_benchmarks` is generated only once.
130130
Tests in a single ReFrame session must have unique names, so the fixture class name is mangled by the framework to generate a unique name in the test dependency DAG.
131131
A *scope* part is added to the base name of the fixture, which in this figure is indicated with red color.
132132

0 commit comments

Comments
 (0)