Skip to content

Commit ab52dab

Browse files
author
Theofilos Manitaras
committed
Address PR comments
1 parent a487fd3 commit ab52dab

File tree

3 files changed

+10
-5
lines changed

3 files changed

+10
-5
lines changed

docs/config_reference.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -467,6 +467,7 @@ ReFrame can launch containerized applications, but you need to configure properl
467467
The type of the container platform.
468468
Available values are the following:
469469

470+
- ``Apptainer``: The `Apptainer <https://apptainer.org/>`__ container runtime.
470471
- ``Docker``: The `Docker <https://www.docker.com/>`__ container runtime.
471472
- ``Sarus``: The `Sarus <https://sarus.readthedocs.io/>`__ container runtime.
472473
- ``Shifter``: The `Shifter <https://github.com/NERSC/shifter>`__ container runtime.

reframe/core/containers.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -268,7 +268,11 @@ def launch_command(self, stagedir):
268268

269269
class Apptainer(Singularity):
270270
'''Container platform backend for running containers with `Apptainer
271-
<https://apptainer.org/>`__.'''
271+
<https://apptainer.org/>`__.
272+
273+
.. versionadded:: 4.0.0
274+
275+
'''
272276

273277
def __init__(self):
274278
super().__init__()

unittests/test_containers.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ def expected_cmd_mount_points(container_variant):
102102
'--mount=type=bind,source="/path/two",destination="/two" '
103103
'--mount=type=bind,source="/foo",destination="/rfm_workdir" '
104104
'load/library/image:tag cmd')
105-
elif container_variant in {'Singularity'}:
105+
elif container_variant == 'Singularity':
106106
return ('singularity exec -B"/path/one:/one" '
107107
'-B"/path/two:/two" -B"/foo:/rfm_workdir" '
108108
'--pwd /rfm_workdir image:tag cmd')
@@ -114,7 +114,7 @@ def expected_cmd_mount_points(container_variant):
114114
return ('singularity run -B"/path/one:/one" '
115115
'-B"/path/two:/two" -B"/foo:/rfm_workdir" '
116116
'--pwd /rfm_workdir image:tag')
117-
elif container_variant in {'Apptainer'}:
117+
elif container_variant == 'Apptainer':
118118
return ('apptainer exec -B"/path/one:/one" '
119119
'-B"/path/two:/two" -B"/foo:/rfm_workdir" '
120120
'--pwd /rfm_workdir image:tag cmd')
@@ -194,7 +194,7 @@ def expected_cmd_run_opts(container_variant):
194194
'--mount=type=bind,source="/path/one",destination="/one" '
195195
'--mount=type=bind,source="/foo",destination="/rfm_workdir" '
196196
'--mpi --foo --bar image:tag cmd')
197-
elif container_variant in {'Singularity'}:
197+
elif container_variant == 'Singularity':
198198
return ('singularity exec -B"/path/one:/one" -B"/foo:/rfm_workdir" '
199199
'--foo --bar image:tag cmd')
200200
elif container_variant == 'Singularity+cuda':
@@ -203,7 +203,7 @@ def expected_cmd_run_opts(container_variant):
203203
elif container_variant == 'Singularity+nocommand':
204204
return ('singularity run -B"/path/one:/one" -B"/foo:/rfm_workdir" '
205205
'--foo --bar image:tag')
206-
elif container_variant in {'Apptainer'}:
206+
elif container_variant == 'Apptainer':
207207
return ('apptainer exec -B"/path/one:/one" -B"/foo:/rfm_workdir" '
208208
'--foo --bar image:tag cmd')
209209
elif container_variant == 'Apptainer+cuda':

0 commit comments

Comments
 (0)