Merge branch 'master' into feat/remove-depreated-attributes

Author: Vasileios Karakasis

.github/workflows/main.yml

@@ -46,3 +46,25 @@ jobs:
     - name: Run Unittests
       run: |
         docker run reframe:${{ matrix.modules-version }}
+
+  flake8:
+    if: github.event_name == 'pull_request'
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v2
+      with:
+        fetch-depth: 0
+    - name: Changed Python Files
+      run: |
+        echo 'CHANGED_PYTHON_FILES<<EOF' >> $GITHUB_ENV
+        git diff --name-only ${{ github.event.pull_request.base.sha }}..${{ github.sha }} | grep '.py' >> $GITHUB_ENV
+        echo 'EOF' >> $GITHUB_ENV
+    - uses: actions/setup-python@v2
+      with:
+        python-version: 3.8
+    - name: Unused Imports Check
+      run: |
+        pip install flake8
+        echo 'Checking Python Files:'
+        for f in "$CHANGED_PYTHON_FILES"; do echo "$f"; done
+        flake8 --select F401 $CHANGED_PYTHON_FILES

reframe/core/buildsystems.py

@@ -426,8 +426,9 @@ def emit_build_commands(self, environ):
             cmd_parts += [nvcc, *cppflags, *cxxflags, self.srcfile,
                           '-o', executable, *ldflags]
         else:
-            BuildSystemError('could not guess language of file: %s' %
-                             self.srcfile)
+            raise BuildSystemError(
+                f'could not guess language of file: {self.srcfile}'
+            )
 
         return [' '.join(cmd_parts)]
 

reframe/frontend/cli.py

@@ -16,7 +16,6 @@
 
 import reframe
 import reframe.core.config as config
-import reframe.core.environments as env
 import reframe.core.exceptions as errors
 import reframe.core.logging as logging
 import reframe.core.runtime as runtime

reframe/frontend/loader.py

@@ -10,12 +10,11 @@
 import ast
 import collections.abc
 import inspect
-import io
 import os
 
 import reframe.utility as util
 import reframe.utility.osext as osext
-from reframe.core.exceptions import NameConflictError, RegressionTestLoadError
+from reframe.core.exceptions import NameConflictError
 from reframe.core.logging import getlogger
 
 

unittests/test_buildsystems.py

@@ -235,3 +235,10 @@ def test_compiler_pick(lang):
     }
     assert ([f'{compilers[lang]} {build_system.srcfile} -o foo.x'] ==
             build_system.emit_build_commands(ProgEnvironment('testenv')))
+
+
+def test_singlesource_unknown_language():
+    build_system = bs.SingleSource()
+    build_system.srcfile = 'foo.bar'
+    with pytest.raises(BuildSystemError, match='could not guess language'):
+        build_system.emit_build_commands(ProgEnvironment('testenv'))

unittests/test_pipeline.py

@@ -457,6 +457,21 @@ def __init__(self):
         test.compile()
 
 
+def test_sourcepath_non_existent(local_exec_ctx):
+    @fixtures.custom_prefix('unittests/resources/checks')
+    class MyTest(rfm.CompileOnlyRegressionTest):
+        def __init__(self):
+            self.valid_prog_environs = ['*']
+            self.valid_systems = ['*']
+
+    test = MyTest()
+    test.setup(*local_exec_ctx)
+    test.sourcepath = 'non_existent.c'
+    test.compile()
+    with pytest.raises(BuildError):
+        test.compile_wait()
+
+
 def test_extra_resources(testsys_system):
     @fixtures.custom_prefix('unittests/resources/checks')
     class MyTest(HelloTest):