fix comments

Author: rsarm

reframe/core/containers.py

@@ -5,7 +5,7 @@
 from reframe.core.exceptions import ContainerError
 
 
-class ContainerPlatform:
+class ContainerPlatform(abc.ABC):
     """The abstract base class of any container platform.
 
     Concrete container platforms inherit from this class and must override the
@@ -64,28 +64,29 @@ def validate(self):
             platforms.
         """
         if self.image is None:
-            raise ContainerError('no image specified.')
+            raise ContainerError('no image specified')
 
         if not self.commands:
-            raise ContainerError('no command specified')
+            raise ContainerError('no commands specified')
 
 
 class Docker(ContainerPlatform):
-    """An implementation of ContainerPlatform to run containers with
-    Docker.
-    """
+    """An implementation of ContainerPlatform to run containers with Docker."""
     def emit_prepare_cmds(self):
         pass
 
-    def emit_launch_commands(self):
+    def emit_launch_cmds(self):
         super().emit_launch_cmds()
-        docker_opts = []
         docker_opts = ['-v "%s":"%s"' % mp for mp in self.mount_points]
         run_cmd = 'docker run %s %s bash -c ' % (' '.join(docker_opts),
                                                  self.image)
         return run_cmd + "'" + '; '.join(
             ['cd ' + self.workdir] + self.commands) + "'"
 
+    def validate(self):
+        super().validate()
+        pass
+
 
 class ContainerPlatformField(fields.TypedField):
     """A field representing a container platforms.

unittests/test_containers.py

@@ -6,7 +6,7 @@
 from reframe.core.exceptions import ContainerError
 
 
-class _ContainerPlatformTest:
+class _ContainerPlatformTest(abc.ABC):
     @abc.abstractmethod
     def create_container_platform(self):
         pass
@@ -30,8 +30,8 @@ def test_mount_points(self):
                                                 ('/path/two', '/two')]
         self.container_platform.commands = ['cmd1', 'cmd2']
         self.container_platform.workdir = '/stagedir'
-        self.assertEqual(self.exp_cmd_mount_points,
-                         self.container_platform.emit_launch_commands())
+        assert (self.exp_cmd_mount_points ==
+                self.container_platform.emit_launch_cmds())
 
     def test_missing_image(self):
         self.container_platform.commands = ['cmd']
@@ -49,8 +49,8 @@ def test_custom_registry(self):
         self.container_platform.commands = ['cmd']
         self.container_platform.mount_points = [('/path/one', '/one')]
         self.container_platform.workdir = '/stagedir'
-        self.assertEqual(self.exp_cmd_custom_registry,
-                         self.container_platform.emit_launch_commands())
+        assert (self.exp_cmd_custom_registry ==
+                self.container_platform.emit_launch_cmds())
 
 
 class TestDocker(_ContainerPlatformTest, unittest.TestCase):