Skip to content

Commit caddaba

Browse files
author
Vasileios Karakasis
committed
Address PR comments
1 parent 3218292 commit caddaba

File tree

5 files changed

+5
-14
lines changed

5 files changed

+5
-14
lines changed

docs/tutorial_deps.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ As a result, its immediate dependency :class:`OSUBuildTest` will be skipped, whi
150150
Listing Dependencies
151151
--------------------
152152

153-
As shown in the listing of :class:`OSULatencyTest` before, the full dependency chain of the test is listed along with test.
153+
As shown in the listing of :class:`OSULatencyTest` before, the full dependency chain of the test is listed along with the test.
154154
Each target dependency is printed in a new line prefixed by the ``^`` character and indented proportionally to its level.
155155
If a target dependency appears in multiple paths, it will only be listed once.
156156

reframe/core/meta.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -482,9 +482,6 @@ def __call__(cls, *args, **kwargs):
482482
if not isinstance(fixt_vars, collections.abc.Mapping):
483483
raise TypeError("'fixt_vars' argument must be a mapping")
484484

485-
# Intercept is_fixture argument to flag an instance as a fixture
486-
# is_fixture = kwargs.pop('is_fixture', False)
487-
488485
obj = cls.__new__(cls, *args, **kwargs)
489486

490487
# Insert the var and param spaces

reframe/schemas/runreport.json

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -98,10 +98,7 @@
9898
"time_total": {"type": ["number", "null"]},
9999
"unique_name": {"type": "string"}
100100
},
101-
"required": [
102-
"environment", "fail_phase", "fail_reason", "filename",
103-
"result", "stagedir", "system", "time_total", "unique_name"
104-
]
101+
"required": ["environment", "stagedir", "system", "unique_name"]
105102
}
106103
},
107104
"type": "object",
@@ -125,7 +122,7 @@
125122
"version": {"type": "string"},
126123
"workdir": {"type": "string"}
127124
},
128-
"required": ["data_version", "hostname", "time_elapsed", "time_start"]
125+
"required": ["data_version"]
129126
},
130127
"restored_cases": {
131128
"type": "array",
@@ -145,9 +142,7 @@
145142
"items": {"$ref": "#/defs/testcase_type"}
146143
}
147144
},
148-
"required": [
149-
"num_cases", "num_failures", "num_aborted", "runid", "testcases"
150-
]
145+
"required": ["testcases"]
151146
}
152147
}
153148
},

tutorials/basics/stream/stream3.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ class StreamWithRefTest(rfm.RegressionTest):
2323
}
2424
reference = {
2525
'catalina': {
26-
'Copy': (55200, -0.05, 0.05, 'MB/s'),
26+
'Copy': (25200, -0.05, 0.05, 'MB/s'),
2727
'Scale': (16800, -0.05, 0.05, 'MB/s'),
2828
'Add': (18500, -0.05, 0.05, 'MB/s'),
2929
'Triad': (18800, -0.05, 0.05, 'MB/s')

unittests/test_parameters.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@ def test_abstract_param():
5050
class MyTest(Abstract):
5151
pass
5252

53-
print(MyTest.param_space)
5453
assert MyTest.param_space['P0'] == ()
5554
assert MyTest.param_space['P1'] == ('b',)
5655

0 commit comments

Comments
 (0)