Merge branch 'master' into feat/module-use-colon-separated-paths

Author: Vasileios Karakasis

.github/workflows/main.yml

@@ -46,3 +46,25 @@ jobs:
     - name: Run Unittests
       run: |
         docker run reframe:${{ matrix.modules-version }}
+
+  flake8:
+    if: github.event_name == 'pull_request'
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v2
+      with:
+        fetch-depth: 0
+    - name: Changed Python Files
+      run: |
+        echo 'CHANGED_PYTHON_FILES<<EOF' >> $GITHUB_ENV
+        git diff --name-only ${{ github.event.pull_request.base.sha }}..${{ github.sha }} | grep '.py' >> $GITHUB_ENV
+        echo 'EOF' >> $GITHUB_ENV
+    - uses: actions/setup-python@v2
+      with:
+        python-version: 3.8
+    - name: Unused Imports Check
+      run: |
+        pip install flake8
+        echo 'Checking Python Files:'
+        for f in "$CHANGED_PYTHON_FILES"; do echo "$f"; done
+        flake8 --select F401 $CHANGED_PYTHON_FILES

docs/migration_2_to_3.rst

@@ -171,6 +171,9 @@ Other deprecations
 The :attr:`prebuild_cmd` and :attr:`postbuild_cmd` test attributes are replaced by the :attr:`prebuild_cmds` and :attr:`postbuild_cmds` respectively.
 Similarly, the :attr:`pre_run` and :attr:`post_run` test attributes are replaced by the :attr:`prerun_cmds` and :attr:`postrun_cmds` respectively.
 
+.. warning::
+   .. versionchanged:: 3.4
+      The :attr:`prebuild_cmd`, :attr:`postbuild_cmd`, :attr:`pre_run` and :attr:`post_run` attributes have been removed.
 
 
 Suppressing deprecation warnings

reframe/core/buildsystems.py

@@ -426,8 +426,9 @@ def emit_build_commands(self, environ):
             cmd_parts += [nvcc, *cppflags, *cxxflags, self.srcfile,
                           '-o', executable, *ldflags]
         else:
-            BuildSystemError('could not guess language of file: %s' %
-                             self.srcfile)
+            raise BuildSystemError(
+                f'could not guess language of file: {self.srcfile}'
+            )
 
         return [' '.join(cmd_parts)]
 

reframe/core/pipeline.py

@@ -32,7 +32,7 @@
 import reframe.utility.udeps as udeps
 from reframe.core.backends import (getlauncher, getscheduler)
 from reframe.core.buildsystems import BuildSystemField
-from reframe.core.containers import ContainerPlatform, ContainerPlatformField
+from reframe.core.containers import ContainerPlatformField
 from reframe.core.deferrable import _DeferredExpression
 from reframe.core.exceptions import (BuildError, DependencyError,
                                      PipelineError, SanityError,
@@ -275,14 +275,6 @@ def pipeline_hooks(cls):
     #: :default: ``[]``
     prebuild_cmds = fields.TypedField('prebuild_cmds', typ.List[str])
 
-    #: .. deprecated:: 3.0
-    #:
-    #: Use :attr:`prebuild_cmds` instead.
-    prebuild_cmd = fields.DeprecatedField(
-        fields.TypedField('prebuild_cmds', typ.List[str]),
-        "'prebuild_cmd' is deprecated; please use 'prebuild_cmds' instead"
-    )
-
     #: .. versionadded:: 3.0
     #:
     #: List of shell commands to be executed after a successful compilation.
@@ -295,14 +287,6 @@ def pipeline_hooks(cls):
     #: :default: ``[]``
     postbuild_cmds = fields.TypedField('postbuild_cmds', typ.List[str])
 
-    #: .. deprecated:: 3.0
-    #:
-    #: Use :attr:`postbuild_cmds` instead.
-    postbuild_cmd = fields.DeprecatedField(
-        fields.TypedField('postbuild_cmds', typ.List[str]),
-        "'postbuild_cmd' is deprecated; please use 'postbuild_cmds' instead"
-    )
-
     #: The name of the executable to be launched during the run phase.
     #:
     #: :type: :class:`str`
@@ -352,14 +336,6 @@ def pipeline_hooks(cls):
     #: :default: ``[]``
     prerun_cmds = fields.TypedField('prerun_cmds', typ.List[str])
 
-    #: .. deprecated:: 3.0
-    #:
-    #: Use :attr:`prerun_cmds` instead.
-    pre_run = fields.DeprecatedField(
-        fields.TypedField('prerun_cmds', typ.List[str]),
-        "'pre_run' is deprecated; please use 'prerun_cmds' instead"
-    )
-
     #: .. versionadded:: 3.0
     #:
     #: List of shell commands to execute after launching this job.
@@ -371,14 +347,6 @@ def pipeline_hooks(cls):
     #: :default: ``[]``
     postrun_cmds = fields.TypedField('postrun_cmds', typ.List[str])
 
-    #: .. deprecated:: 3.0
-    #:
-    #: Use :attr:`postrun_cmds` instead.
-    post_run = fields.DeprecatedField(
-        fields.TypedField('postrun_cmds', typ.List[str]),
-        "'post_run' is deprecated; please use 'postrun_cmds' instead"
-    )
-
     #: List of files to be kept after the test finishes.
     #:
     #: By default, the framework saves the standard output, the standard error

reframe/frontend/cli.py

@@ -16,7 +16,6 @@
 
 import reframe
 import reframe.core.config as config
-import reframe.core.environments as env
 import reframe.core.exceptions as errors
 import reframe.core.logging as logging
 import reframe.core.runtime as runtime

reframe/frontend/loader.py

@@ -10,12 +10,11 @@
 import ast
 import collections.abc
 import inspect
-import io
 import os
 
 import reframe.utility as util
 import reframe.utility.osext as osext
-from reframe.core.exceptions import NameConflictError, RegressionTestLoadError
+from reframe.core.exceptions import NameConflictError
 from reframe.core.logging import getlogger
 
 

unittests/test_buildsystems.py

@@ -233,3 +233,10 @@ def test_compiler_pick(lang):
     }
     assert ([f'{compilers[lang]} {build_system.srcfile} -o foo.x'] ==
             build_system.emit_build_commands(ProgEnvironment('testenv')))
+
+
+def test_singlesource_unknown_language():
+    build_system = bs.SingleSource()
+    build_system.srcfile = 'foo.bar'
+    with pytest.raises(BuildSystemError, match='could not guess language'):
+        build_system.emit_build_commands(ProgEnvironment('testenv'))

unittests/test_pipeline.py

@@ -455,6 +455,21 @@ def __init__(self):
         test.compile()
 
 
+def test_sourcepath_non_existent(local_exec_ctx):
+    @fixtures.custom_prefix('unittests/resources/checks')
+    class MyTest(rfm.CompileOnlyRegressionTest):
+        def __init__(self):
+            self.valid_prog_environs = ['*']
+            self.valid_systems = ['*']
+
+    test = MyTest()
+    test.setup(*local_exec_ctx)
+    test.sourcepath = 'non_existent.c'
+    test.compile()
+    with pytest.raises(BuildError):
+        test.compile_wait()
+
+
 def test_extra_resources(testsys_system):
     @fixtures.custom_prefix('unittests/resources/checks')
     class MyTest(HelloTest):