Raise ValueError for invalid pipeline stages

Author: Vasileios Karakasis

reframe/core/decorators.py

@@ -214,6 +214,13 @@ def _fn(*args, **kwargs):
     return deco
 
 
+# Valid pipeline stages that users can specify in the `run_before()` and
+# `run_after()` decorators
+_USER_PIPELINE_STAGES = (
+    'init', 'setup', 'compile', 'run', 'sanity', 'performance', 'cleanup'
+)
+
+
 def run_before(stage):
     '''Decorator for attaching a test method to a pipeline stage.
 
@@ -227,6 +234,9 @@ def run_before(stage):
     ``'run'``, ``'sanity'``, ``'performance'`` or ``'cleanup'``.
 
     '''
+    if stage not in _USER_PIPELINE_STAGES:
+        raise ValueError(f'invalid pipeline stage specified: {stage!r}')
+
     if stage == 'init':
         raise ValueError('pre-init hooks are not allowed')
 
@@ -263,6 +273,9 @@ def __init__(self):
 
     '''
 
+    if stage not in _USER_PIPELINE_STAGES:
+        raise ValueError(f'invalid pipeline stage specified: {stage!r}')
+
     # Map user stage names to the actual pipeline functions if needed
     if stage == 'init':
         stage = '__init__'

unittests/test_pipeline.py

@@ -526,9 +526,24 @@ def set_resources(self):
     assert expected_job_options == set(test.job.options)
 
 
-def test_pre_init_hook(local_exec_ctx):
+def test_unkown_pre_hook():
+    with pytest.raises(ValueError):
+        class MyTest(rfm.RunOnlyRegressionTest):
+            @rfm.run_before('foo')
+            def prepare(self):
+                self.x = 1
+
+
+def test_unkown_post_hook():
+    with pytest.raises(ValueError):
+        class MyTest(rfm.RunOnlyRegressionTest):
+            @rfm.run_after('foo')
+            def prepare(self):
+                self.x = 1
+
+
+def test_pre_init_hook():
     with pytest.raises(ValueError):
-        @fixtures.custom_prefix('unittests/resources/checks')
         class MyTest(rfm.RunOnlyRegressionTest):
             @rfm.run_before('init')
             def prepare(self):