Merge pull request #1630 from teojgo/feat/disable_old_settings

[feat] Drop support for old configuration syntax

Author: Vasileios Karakasis

docs/migration_2_to_3.rst

@@ -14,23 +14,18 @@ Updating Your Site Configuration
 --------------------------------
 
 As described in `Configuring ReFrame for Your Site <configure.html>`__, ReFrame's configuration file has changed substantially.
-However, you don't need to manually update your configuration; ReFrame will do that automatically for you.
-As soon as it detects an old-style configuration file, it will convert it to the new syntax save it in a temporary file:
-
-
-.. code-block:: none
-
-   $ ./bin/reframe -C unittests/resources/settings_old_syntax.py -l
-   ./bin/reframe: the syntax of the configuration file 'unittests/resources/settings_old_syntax.py' is deprecated
-   ./bin/reframe: configuration file has been converted to the new syntax here: '/var/folders/h7/k7cgrdl13r996m4dmsvjq7v80000gp/T/tmph5n8u3kf.py'
-
-Alternatively, you can convert any old configuration file using the command line option :option:`--upgrade-config-file`:
+However, you can convert any old configuration file using the command line option :option:`--upgrade-config-file`:
 
 .. code-block:: none
 
    $ ./bin/reframe --upgrade-config-file unittests/resources/settings_old_syntax.py:new_config.py
    Conversion successful! The converted file can be found at 'new_config.py'.
 
+.. warning::
+   .. versionchanged:: 3.4
+      The old configuration syntax in no longer supported and it will not be automatically converted by the `-C` option.
+
+
 Another important change is that default locations for looking up a configuration file has changed (see `Configuring ReFrame for Your Site <configure.html>`__ for more details).
 That practically means that if you were relying on ReFrame loading your ``reframe/settings.py`` by default, this is no longer true.
 You have to move it to any of the default settings locations or set the corresponding command line option or environment variable.
@@ -39,8 +34,8 @@ You have to move it to any of the default settings locations or set the correspo
    The conversion tool will create a JSON configuration file if the extension of the target file is ``.json``.
 
 
-Automatic conversion limitations
-================================
+Configuration conversion limitations
+====================================
 
 ReFrame does a pretty good job in converting correctly your old configuration files, but there are some limitations:
 

reframe/core/config.py

@@ -15,15 +15,11 @@
 import tempfile
 
 import reframe
-import reframe.core.fields as fields
 import reframe.core.settings as settings
 import reframe.utility as util
-import reframe.utility.osext as osext
-import reframe.utility.typecheck as types
 from reframe.core.environments import normalize_module_list
 from reframe.core.exceptions import ConfigError, ReframeFatalError
 from reframe.core.logging import getlogger
-from reframe.core.warnings import ReframeDeprecationWarning
 from reframe.utility import ScopedDict
 
 
@@ -229,9 +225,10 @@ def _create_from_python(cls, filename):
 
         if hasattr(mod, 'settings'):
             # Looks like an old style config
-            raise ReframeDeprecationWarning(
-                f"the syntax of the configuration file '{filename}' "
-                f"is deprecated"
+            raise ConfigError(
+                f"the syntax of the configuration file {filename!r} "
+                f"is no longer supported; please convert it using the "
+                f"'--upgrade-config-file' option"
             )
 
         mod = util.import_module_from_file(filename)

unittests/test_config.py

@@ -4,13 +4,11 @@
 # SPDX-License-Identifier: BSD-3-Clause
 
 import json
-import os
 import pytest
 
 import reframe.core.config as config
 from reframe.core.exceptions import ConfigError
 from reframe.core.systems import System
-from reframe.core.warnings import ReframeDeprecationWarning
 
 
 def test_load_config_fallback(monkeypatch):
@@ -24,7 +22,7 @@ def test_load_config_python():
 
 
 def test_load_config_python_old_syntax():
-    with pytest.raises(ReframeDeprecationWarning):
+    with pytest.raises(ConfigError):
         site_config = config.load_config(
             'unittests/resources/settings_old_syntax.py'
         )