Skip to content

Commit ef5ca62

Browse files
author
Vasileios Karakasis
committed
Address PR comments
1 parent 2c63a4c commit ef5ca62

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

docs/tutorial_basics.rst

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
.. versionadded:: 3.1
66

7-
This tutorial will give you a first overview of ReFrame and will acquaint with its basic concepts.
7+
This tutorial will give you a first overview of ReFrame and will acquaint you with its basic concepts.
88
We will start with a simple "Hello, World!" test running with the default configuration and we will expand the example along the way.
99
We will also explore performance tests and we will port our tests to an HPC cluster.
1010
The examples of this tutorial can be found under :obj:`tutorials/basics/`.
@@ -130,7 +130,7 @@ Let's inspect what files ReFrame produced for this test:
130130
rfm_HelloTest_build.err rfm_HelloTest_build.sh rfm_HelloTest_job.out
131131
rfm_HelloTest_build.out rfm_HelloTest_job.err rfm_HelloTest_job.sh
132132
133-
ReFrame stores in the output directory of the test the build and "job" scripts it generated for building and running the code along with their standard output and error.
133+
ReFrame stores in the output directory of the test the build and run scripts it generated for building and running the code along with their standard output and error.
134134
All these files are prefixed with ``rfm_``.
135135

136136

@@ -915,7 +915,7 @@ In ReFrame, you don't have to care about all the system interaction details, but
915915
Adapting a test to new systems and programming environments
916916
-----------------------------------------------------------
917917

918-
Unless a test is rather generic, you will need to do some adaptations for the system that you port it to.
918+
Unless a test is rather generic, you will need to make some adaptations for the system that you port it to.
919919
In this case, we will adapt the STREAM benchmark so as to run it with multiple compiler and adjust its execution parameters based on the target architecture of each partition.
920920
Let's see and comment the changes:
921921

docs/tutorial_misc_topics.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -354,7 +354,7 @@ ReFrame will run the container as follows:
354354
singularity exec -B"/path/to/test/stagedir:/workdir" docker://ubuntu:18.04 bash -c 'cd rfm_workdir; pwd; ls; cat /etc/os-release'
355355
356356
By default ReFrame will mount the stage directory of the test under ``/rfm_workdir`` inside the container and it will always prepend a ``cd`` command to that directory.
357-
The user commands then are then run from that directory one after the other.
357+
The user commands are then run from that directory one after the other.
358358
Once the commands are executed, the container is stopped and ReFrame goes on with the sanity and performance checks.
359359
Users may also change the default mount point of the stage directory by using :attr:`workdir <reframe.core.pipeline.RegressionTest.container_platform.workdir>` attribute:
360360
Besides the stage directory, additional mount points can be specified through the :attr:`mount_points <reframe.core.pipeline.RegressionTest.container_platform.mount_points>` attribute:

0 commit comments

Comments
 (0)