[feat] Support multiple aggregations and statistics at once when querying performance data #3585
+443
−324
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR offers the following features:
statsaggregator. These includes mean, standard deviation, and 0.01, 0.05, 0.50, 0.95, 0.99 quantiles.mean,min,max, and also aggregations on values other than the performance, e.g.,min(num_tasks),min(pref)etc.--term-lhsand--term-rhsand are only meaningful with the--performance-compareand--performance-reportoptions.(lhs)and(rhs)respectively._Land_Rinstead of_Aand_B.Closes #3436.
Implementation details
The analytics layers is now using Polars through its Python bindings.
Managing the column names was the most challenging part of the implementation, as we wanted to keep a straightforward for selecting test attributes from the command line, specifying the left/right variants quickly and the same time produce tables with meaningful headers (e.g., include the aggregation in the column name, especially now, that multiple aggregations are supported at once). This is handled the the internal
_QueryMatchclass which replaces the very thin former_Matchnamed tuple.Todos
Notes
If the CI does not pass for Python < 3.9, we should simply merge this PR after #3583 is addressed.