Merge pull request #8 from regeda/dont_add_to_grid

Don't add a value to the grid

Author: regeda

Makefile

@@ -1,4 +1,4 @@
-.PHONY: gen-proto gen-fbs gen-lexer test bench bench-report
+.PHONY: gen-proto gen-fbs gen-lexer test bench bench-report escape-analysis
 
 default: test
 
@@ -22,3 +22,5 @@ bench: test
 
 bench-report: bench
 	@go tool pprof -web cpu.out
+
+escape-analysis: ; @go test -gcflags="-m" ./...

README.md

@@ -170,5 +170,5 @@ equals("foo,bar,baz", join(",", ["foo", "bar", "baz"]))
 ```
 cpu: Intel(R) Core(TM) i5-8259U CPU @ 2.30GHz
 BenchmarkExec
-BenchmarkExec-8          1432002               833.2 ns/op             0 B/op          0 allocs/op
+BenchmarkExec-8          1508277               798.5 ns/op             0 B/op          0 allocs/op
 ```

memory/grid.go

@@ -25,10 +25,3 @@ func (g *grid) alloc(n uint32) []Addr {
 func (g *grid) reset() {
 	g.off = 0
 }
-
-func (g *grid) add(a Addr) Addr {
-	g.grow(1)
-	g.buf[g.off] = a
-	g.off++
-	return a
-}

memory/memory.go

@@ -45,14 +45,7 @@ func (b *Memory) Reset() {
 
 func (b *Memory) alloc(t Type, size uint32) Addr {
 	buf := b.h.alloc(size)
-	return b.allocAddr(t, buf)
-}
-
-func (b *Memory) allocAddr(t Type, dat []byte) Addr {
-	return b.g.add(Addr{
-		typ: t,
-		dat: dat,
-	})
+	return NewAddr(t, buf...)
 }
 
 func (b *Memory) Alloc(in interface{}) (Addr, error) {
@@ -86,7 +79,7 @@ func (b *Memory) Alloc(in interface{}) (Addr, error) {
 }
 
 func (b *Memory) AllocBytesAddr(dat []byte) Addr {
-	return b.allocAddr(TypeBytes, dat)
+	return NewAddr(TypeBytes, dat...)
 }
 
 func (b *Memory) AllocBytes(size uint32) Addr {
@@ -103,7 +96,7 @@ func (b *Memory) AllocInt64(v int64) Addr {
 }
 
 func (b *Memory) AllocVector(size uint32) Addr {
-	addr := b.allocAddr(TypeVector, nil)
+	addr := NewAddr(TypeVector)
 	addr.vec = b.g.alloc(size)
 	return addr
 }