fix: stop user menu closing on click in desktop

r41ph · r41ph · commit 309708f7cc22 · 2025-02-06T10:41:15.000Z
diff --git a/web-components/src/components/header/components/HeaderMenuItem/HeaderMenuItem.Hover.tsx b/web-components/src/components/header/components/HeaderMenuItem/HeaderMenuItem.Hover.tsx
@@ -75,7 +75,7 @@ const HeaderMenuItemHover = ({
                 ? ' animate-menuClose pointer-events-none'
                 : ' hidden')
         }`}
-        onClick={closeMenu}
+        onClick={isTouchScreen ? closeMenu : undefined}
       >
         <MenuList
           className="bg-grey-0 rounded-[4px] border border-solid border-grey-300 shadow-[0px_5px_5px_-3px_rgba(0,0,0,0.2),_0px_8px_10px_1px_rgba(0,0,0,0.14),_0px_3px_14px_2px_rgba(0,0,0,0.12)]"

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ const HeaderMenuItemHover = ({`
`75`	`75`	`? ' animate-menuClose pointer-events-none'`
`76`	`76`	`: ' hidden')`
`77`	`77`	}`}
`78`		`- onClick={closeMenu}`
	`78`	`+ onClick={isTouchScreen ? closeMenu : undefined}`
`79`	`79`	`>`
`80`	`80`	`<MenuList`
`81`	`81`	`className="bg-grey-0 rounded-[4px] border border-solid border-grey-300 shadow-[0px_5px_5px_-3px_rgba(0,0,0,0.2),_0px_8px_10px_1px_rgba(0,0,0,0.14),_0px_3px_14px_2px_rgba(0,0,0,0.12)]"`