fix: APP-406 email always required when buying with credit card (#2580)

Author: blushi

web-marketplace/src/components/organisms/PaymentInfoForm/PaymentInfoForm.CustomerInfo.tsx

@@ -76,9 +76,9 @@ export const CustomerInfo = ({
             <Trans>
               Input an email address to receive a receipt of your purchase.
               <i>
-                Take note: we will email you a prompt to associate this email
-                with your account for easier future access. This is entirely
-                optional.
+                Note: You will receive an email with instructions to link this
+                email to your account, allowing for easier access going forward,
+                if desired.
               </i>
             </Trans>
           ) : paymentOption === PAYMENT_OPTIONS.CARD ? (
@@ -95,7 +95,7 @@ export const CustomerInfo = ({
         error={!!errors['email']}
         helperText={errors['email']?.message}
         disabled={!!accountEmail}
-        optional={!!wallet?.address}
+        optional={paymentOption === PAYMENT_OPTIONS.CRYPTO}
       />
       {!accountId && !wallet?.address && (
         <CheckboxLabel

web-marketplace/src/components/organisms/PaymentInfoForm/PaymentInfoForm.schema.ts

@@ -1,19 +1,14 @@
 import { z } from 'zod';
 
-import { Wallet } from 'lib/wallet/wallet';
-
 import { PAYMENT_OPTIONS } from 'pages/BuyCredits/BuyCredits.constants';
 import { PaymentOptionsType } from 'pages/BuyCredits/BuyCredits.types';
 
-export const paymentInfoFormSchema = (
-  paymentOption: PaymentOptionsType,
-  wallet?: Wallet,
-) =>
+export const paymentInfoFormSchema = (paymentOption: PaymentOptionsType) =>
   z.object({
     name:
       paymentOption === PAYMENT_OPTIONS.CARD ? z.string().min(1) : z.string(),
     email:
-      paymentOption === PAYMENT_OPTIONS.CARD && !wallet?.address
+      paymentOption === PAYMENT_OPTIONS.CARD
         ? z.string().email().min(1)
         : z.union([z.literal(''), z.string().email().nullable()]),
     createAccount: z.boolean(),

web-marketplace/src/components/organisms/PaymentInfoForm/PaymentInfoForm.tsx

@@ -59,7 +59,7 @@ export const PaymentInfoForm = ({
   const [paymentInfoValid, setPaymentInfoValid] = useState(false);
 
   const form = useZodForm({
-    schema: paymentInfoFormSchema(paymentOption, wallet),
+    schema: paymentInfoFormSchema(paymentOption),
     defaultValues: {
       email: initialValues?.email || accountEmail,
       name: initialValues?.name || accountName,

web-marketplace/src/lib/i18n/locales/en.po

@@ -2223,9 +2223,13 @@ msgid "Information"
 msgstr ""
 
 #: src/components/organisms/PaymentInfoForm/PaymentInfoForm.CustomerInfo.tsx:76
-msgid "Input an email address to receive a receipt of your purchase.<0>Take note: we will email you a prompt to associate this email with your account for easier future access. This is entirely optional.</0>"
+msgid "Input an email address to receive a receipt of your purchase.<0>Note: You will receive an email with instructions to link this email to your account, allowing for easier access going forward, if desired.</0>"
 msgstr ""
 
+#: src/components/organisms/PaymentInfoForm/PaymentInfoForm.CustomerInfo.tsx:76
+#~ msgid "Input an email address to receive a receipt of your purchase.<0>Take note: we will email you a prompt to associate this email with your account for easier future access. This is entirely optional.</0>"
+#~ msgstr ""
+
 #: src/pages/BuyCredits/BuyCredits.constants.ts:8
 msgid "Insufficient balance"
 msgstr ""

web-marketplace/src/lib/i18n/locales/es.po

@@ -22,9 +22,6 @@ msgstr ""
 #: src/components/organisms/CreditActivityTable/CreditActivityTable.tsx:65
 #: src/components/organisms/Documentation/Documentation.constants.ts:11
 #: src/pages/CreditClassDetails/CreditClassDetailsWithContent/CreditClassDetailsWithContent.constants.ts:35
-msgid ""
-msgstr ""
-
 #: src/lib/constants/shared.constants.tsx:96
 msgid "- see less"
 msgstr "- ver menos"
@@ -2225,8 +2222,12 @@ msgid "Information"
 msgstr "Información"
 
 #: src/components/organisms/PaymentInfoForm/PaymentInfoForm.CustomerInfo.tsx:76
-msgid "Input an email address to receive a receipt of your purchase.<0>Take note: we will email you a prompt to associate this email with your account for easier future access. This is entirely optional.</0>"
-msgstr "Ingresa una dirección de correo electrónico para recibir un recibo de tu compra.<0>Toma nota: te enviaremos un correo electrónico con un mensaje para que asocies este correo electrónico con tu cuenta para facilitar el acceso en el futuro. Esto es completamente opcional.</0>"
+msgid "Input an email address to receive a receipt of your purchase.<0>Note: You will receive an email with instructions to link this email to your account, allowing for easier access going forward, if desired.</0>"
+msgstr "Ingrese una dirección de correo electrónico para recibir un recibo de su compra.<0>Nota: Recibirá un correo electrónico con instrucciones para vincular este correo electrónico a su cuenta, lo que permitirá un acceso más fácil en el futuro, si lo desea.</0>"
+
+#: src/components/organisms/PaymentInfoForm/PaymentInfoForm.CustomerInfo.tsx:76
+#~ msgid "Input an email address to receive a receipt of your purchase.<0>Take note: we will email you a prompt to associate this email with your account for easier future access. This is entirely optional.</0>"
+#~ msgstr "Ingresa una dirección de correo electrónico para recibir un recibo de tu compra.<0>Toma nota: te enviaremos un correo electrónico con un mensaje para que asocies este correo electrónico con tu cuenta para facilitar el acceso en el futuro. Esto es completamente opcional.</0>"
 
 #: src/pages/BuyCredits/BuyCredits.constants.ts:8
 msgid "Insufficient balance"