chore: review comments

Author: blushi

web-components/src/components/cards/MemberCard/MemberCard.tsx

@@ -21,7 +21,10 @@ export const MemberCard = ({
   editText,
   linkComponent: LinkComponent,
 }: Props) => (
-  <article className="bg-grey-0 flex flex-col items-center relative px-20 py-40 border border-solid border-sc-card-standard-stroke rounded-[10px] shadow-[0_0_4px_0_rgba(0,0,0,0.05)]">
+  <article
+    aria-label={name}
+    className="bg-grey-0 flex flex-col items-center relative px-20 py-40 border border-solid border-sc-card-standard-stroke rounded-[10px] shadow-[0_0_4px_0_rgba(0,0,0,0.05)]"
+  >
     <UserAvatar src={imageSrc} alt={name} className="w-[120px] h-[120px]" />
     <Title className="py-10" variant="h6">
       {name}

web-marketplace/src/components/atoms/Link.tsx

@@ -51,13 +51,15 @@ const createMuiLink = (
     ({ href, children, target, ...linkProps }, ref) => {
       const locale = useCurrentLocale();
       if (!href || typeof href !== 'string') {
-        // @ts-expect-error
-        return <Box {...linkProps}>{children}</Box>;
+        return (
+          <Box {...linkProps} component="span">
+            {children}
+          </Box>
+        );
       }
 
       const isInternalLink = (href: string): boolean =>
         !!href && href.startsWith('/');
-      // const hasAnchor = href?.includes('#');
 
       const internalHref =
         applyLocalePrefix && isInternalLink(href)

web-marketplace/src/components/organisms/RegistryLayout/RegistryLayout.tsx

@@ -6,7 +6,7 @@ export const RegistryLayout = () => {
       <ScrollRestoration
         getKey={(location, matches) => {
           const profileMatch = matches.find(match =>
-            match.pathname.includes('/profiles/'),
+            match.pathname.startsWith('/profiles/'),
           );
           return profileMatch ? profileMatch.pathname : location.key;
         }}

web-marketplace/src/legacy-pages/Profile/Profile.tsx

@@ -1,11 +1,5 @@
 import { useMemo, useState } from 'react';
-import {
-  Outlet,
-  ScrollRestoration,
-  useLocation,
-  useNavigate,
-  useParams,
-} from 'react-router-dom';
+import { Outlet, useLocation, useParams } from 'react-router-dom';
 import { msg } from '@lingui/core/macro';
 import { useLingui } from '@lingui/react';
 import { Box } from '@mui/material';
@@ -231,7 +225,12 @@ export const Profile = (): JSX.Element => {
     description: account?.description?.trimEnd() ?? '',
     socialsLinks,
   };
-  const navigate = useNavigate();
+
+  const editLink = isOwnProfile
+    ? organization
+      ? '/dashboard/organization/profile'
+      : '/dashboard/profile'
+    : '';
 
   return (
     <WithLoader
@@ -257,13 +256,7 @@ export const Profile = (): JSX.Element => {
               backgroundImage={backgroundImage}
               avatar={avatarImage}
               infos={infos}
-              editLink={
-                isOwnProfile
-                  ? organization
-                    ? '/dashboard/organization/profile'
-                    : '/dashboard/profile'
-                  : ''
-              }
+              editLink={editLink}
               profileLink={profileLink}
               variant={
                 account?.type