Fix selected header columns with no name (#95)

Generate a unique name for columns with no heading text.

Author: rossjones

fixtures/trailing-column.csv

@@ -0,0 +1,2 @@
+A,B,
+1,2,

lib/importer/backend.test.js

@@ -10,7 +10,7 @@ const testFiles = new Map([
   ["merged-cells", [
     ["merged-cells.xlsx", "Cool Data"],
     ["merged-cells.csv", "Sheet1"]
-    //["merged-cells.ods", "Cool Data"]
+    // ["merged-cells.ods", "Cool Data"]
   ]],
   ["tribbles", [
     ["tribbles.xlsx", "My lovely tribbles"],

lib/importer/sheets.js

@@ -15,7 +15,17 @@ exports.ListSheets = (session) => {
 // it's intended for driving a list of available columns in the header.
 exports.GetHeader = (session) => {
   const headerSample = backend.SessionGetInputSampleRows(session.backendSid, session.headerRange, 1, 0, 0);
-  return headerSample[0][0].map((sample) => sample.value);
+  let untitledCount = 1;
+  return headerSample[0][0].reduce((acc, sample) => {
+    let columnName = sample ? sample.value : (() => {
+      let name = `[Untitled column ${untitledCount}]`;
+      untitledCount += 1;
+      return name;
+    })();
+
+    acc.push(columnName);
+    return acc
+  }, []);
 };
 
 function processMergedCells(wantedColumns, preview) {

lib/importer/sheets.test.js

@@ -0,0 +1,33 @@
+const session_lib = require('./session');
+const sheets_lib = require('./sheets');
+
+test('trailing columns', () => {
+    const response = session_lib.CreateSession(
+        {
+            fields: ['field'],
+            uploadPath: "../../fixtures",
+        },
+        {
+            file: {
+                mimetype: "text/csv",
+                filename: "trailing-column.csv"
+            }
+        }
+    );
+
+    expect(response.error).toBe(undefined);
+    expect(response.id).not.toBe('');
+
+    const session = response.session
+    session.sheet = "Sheet1" // It's a CSV, and this is the default sheet name
+    session.headerRange = {
+        sheet: session.sheet,
+        start: {row: 0, column: 0},
+        end: {row: 0, column: 2},
+      };
+
+
+    let headers = sheets_lib.GetHeader(session)
+    expect(headers.length).toBe(3);
+    expect(headers).toStrictEqual(['A', 'B', '[Untitled column 1]'])
+});