Add version matrix to lint, codeql and test (#326)

As the prototype kit requires any nodejs version after 16, this PR introduces test matrices for codeql, linting and tests for versions from v16 onwards.

We don't lint v16 or v18 as they are not supported by our linter.
We don't test v16 as it is unsupported by our test framework.

Author: rossjones

.github/workflows/codeql.yml

@@ -10,7 +10,7 @@ on:
 
 jobs:
   analyze:
-    name: Analyze (${{ matrix.language }})
+    name: Analyze (${{ matrix.language }}${{ matrix.node-version && format(' - Node.js {0}', matrix.node-version) || '' }})
     # Runner size impacts CodeQL analysis time. To learn more, please see:
     #   - https://gh.io/recommended-hardware-resources-for-running-codeql
     #   - https://gh.io/supported-runners-and-hardware-resources
@@ -36,12 +36,32 @@ jobs:
           build-mode: none
         - language: javascript-typescript
           build-mode: none
+          node-version: '16'
+        - language: javascript-typescript
+          build-mode: none
+          node-version: '18'
+        - language: javascript-typescript
+          build-mode: none
+          node-version: '20'
+        - language: javascript-typescript
+          build-mode: none
+          node-version: '22'
+        - language: javascript-typescript
+          build-mode: none
+          node-version: '24'
         - language: python
           build-mode: none
     steps:
     - name: Checkout repository
       uses: actions/checkout@v4
 
+    # Setup Node.js for JavaScript/TypeScript analysis
+    - name: Setup Node.js
+      if: matrix.language == 'javascript-typescript'
+      uses: actions/setup-node@v4
+      with:
+        node-version: ${{ matrix.node-version }}
+
     # Initializes the CodeQL tools for scanning.
     - name: Initialize CodeQL
       uses: github/codeql-action/init@v3

.github/workflows/lint.yml

@@ -1,21 +1,25 @@
 name: Lint JS
 on:
   push:
-    branches: [main]
+    branches: [ main ]
   pull_request:
-    branches: [main]
+    branches: [ main ]
 jobs:
   lint-importer:
     defaults:
       run:
         working-directory: ./lib/importer
     timeout-minutes: 5
     runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        node-version: [ '20', '22', '24' ]
+    name: Lint Importer (Node.js ${{ matrix.node-version }})
     steps:
     - uses: actions/checkout@v4
     - uses: actions/setup-node@v4
       with:
-        node-version: lts/*
+        node-version: ${{ matrix.node-version }}
     - name: Install dependencies
       run: npm i
     - name: Run linter

.github/workflows/test.yml

@@ -1,21 +1,25 @@
 name: Tests
 on:
   push:
-    branches: [main]
+    branches: [ main ]
   pull_request:
-    branches: [main]
+    branches: [ main ]
 jobs:
   test:
     defaults:
       run:
         working-directory: ./prototypes/basic
     timeout-minutes: 60
     runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        node-version: [ '18', '20', '22', '24' ]
+    name: Test (Node.js ${{ matrix.node-version }})
     steps:
     - uses: actions/checkout@v4
     - uses: actions/setup-node@v4
       with:
-        node-version: lts/*
+        node-version: ${{ matrix.node-version }}
     - name: Install lib dependencies -- todo, check why
       working-directory: ./lib/importer
       run: npm i
@@ -28,7 +32,7 @@ jobs:
     - uses: actions/upload-artifact@v4
       if: always()
       with:
-        name: test-results
+        name: test-results-node-${{ matrix.node-version }}
         path: ./prototypes/basic/test-results
         retention-days: 30
   importer:
@@ -37,11 +41,15 @@ jobs:
         working-directory: ./lib/importer
     timeout-minutes: 60
     runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        node-version: [ '18', '20', '22', '24' ]
+    name: Test Importer (Node.js ${{ matrix.node-version }})
     steps:
     - uses: actions/checkout@v4
     - uses: actions/setup-node@v4
       with:
-        node-version: lts/*
+        node-version: ${{ matrix.node-version }}
     - name: Install lib dependencies
       run: npm i
     - name: Run tests

lib/importer/src/dudk/sheets.js

@@ -422,22 +422,24 @@ const remapErrorStructure = (errors, row_data, mappingIndices, headerRangeOffset
         }
     }
 
-    // Convert the nested maps/sets to the desired array structure
-    return Array.from(messageMap.values().map((errorObj) => {
-        // Some rows may not have any errors because they are for surrounding context,
-        // so we need to filter them out for the meta info
+    // Collect error structures for each value in the messageMap, avoiding
+    // .values().map(...) as that is not supported in earlier versions
+    // of node
+    const errorsOut = []
+    for( const errorObj of messageMap.values()) {
         const errorRows = Array.from(errorObj.rows.values()).filter(rowObj => rowObj.error);
-
-        return {
+        errorsOut.push({
             type: errorObj.type,
             meta: {
                 first: errorRows[0]?.index || 0,
                 count: errorRows?.length || 0
             },
             field: errorObj.field,
             rows: Array.from(errorObj.rows.values())
-        }
-    }));
+        })
+    }
+
+    return Array.from(errorsOut);
 }
 
 exports.RemapErrorStructure = remapErrorStructure