Added missing test fixture files (and some comments)

Author: alaricsp

fixtures/test-validation.csv

@@ -0,0 +1,9 @@
+TEST SPREADSHEET,,,,,,
+required string,required number,optional string,optional number,,,
+Name,Age,Egginess,Weight,,Valid?,Comment
+Boris,13,High,5.5,,TRUE,All fields present
+,,,,,FALSE,All fields blank; row will be silently ignored
+Nelly,10,,,,TRUE,Optional fields absent
+Sid,twelve,,,,FALSE,Invalid required number
+,nine,,,,FALSE,"Missing required string, invalid required number"
+Dave,15,,unknown,,TRUE,Invalid optional number

fixtures/test-validation.ods

@@ -2,26 +2,6 @@
 // simple string/boolean/number/date/etc things. "attribute values" are the
 // actual attributes in our output data model and can be some arbitrary type.
 
-// Am attribute type is a pair of functions.
-
-// One validates an input value to see if it can be made into a valid attribute
-// value. It should return a list of warnings and a list of errors.
-
-// One maps an input value to a value of the attribute type.
-
-// ABS TODOs: Make validation and translation happen together - drop
-// AttributeType and just implement it as a function from input value ->
-// (outputValue, [warning], [error]).
-
-// This will enable optionalType to handle errors from the base type by turning
-// them into warnings *and* returning undefined as the translater value.
-
-// Then add a requiredType that wraps any type and makes it "required", treating
-// "" or undefined inputs as errors.
-
-// Base types without being wrapped by requiredType or optionalType may then
-// handled undefined or "" as they see fit.
-
 // An attribute type is a function from an input value to a result.
 
 class AttributeMappingResult {

fixtures/test-validation.xlsx

@@ -505,7 +505,7 @@ test('validation', () => {
       warningCount: 1
     });
 
-    const warnings = backend.JobGetWarnings(jid);
+    const warnings = backend.JobGetWarnings(jid); // Weight is optional so errors here become warnings
     expect(warnings).toMatchObject(new Map([[8, [['Weight', 'This is not a valid number']]]]));
 
     const errors = backend.JobGetErrors(jid);